[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 15:11:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nw2w4nqLCdZLnnBWhs6E0rXyEuT75m9g3M9OCtBTI3g=; b=HaX53deg4BE2cwjBxBDw90J0KqL0zYy7mCWgziuYiaPA6/lQYx/ulW3jMGMvBMPW3EbcqLb3Rey01sCDz2KH7RtCqHwTeifvaA+hafKej6czsU2qzLS7dGKcflPAIENgE+3LEttOBKft4KxGMOGpE4zaYnp+LR1WIz/EZfodVQq0c+PStVnvsNm+hFlR+pbXYIWqlRlquuhaliDlg6KaVRGPPsp3ioGIr/V+p6Lq4cmL8gUIlAqYxi+Jui27iXS0vYd69dz9sa818S+ohFgkpVxePeaQFRKdVAPrOztDvSac5Ic4yxswtMEMpKcYvjKbA992CSLcV5l/9g/v8sGAvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHn4GBhcfzXjOj3FvuSCWnJkh2A9IlPEjSv3iTPCs7G/T9MX8Rauy5IegQpmv5E2Vf9DZ/8Ra7tYVakS37ocT6O2E3zz7zYSBG//AmOWipE8jYUmd35bXwiNaT5MTiK4N4P2E2LBFc3S+3sgvh5aLf0/ngpLfbeJ4JCdwE+u4y63I+uOzz8yhh3td/TIaHpwhCaFSIAFuC5J2b3IXpo4AR0eLVX4utAFPQS2pe19hyOkxv/WheSz1+krrjZ8vAL9HJJ+ivo9fllQUZ4JYw3f1qNrukxNcqfYp20C3rdOY0XdAho01Hy4Y3pAP+9hedK4iuyo0W3N1ubavjqeF2BARQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 13:11:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 15:08, Jan Beulich wrote:
> On 08.08.2023 15:03, Alejandro Vallejo wrote:
>> --- a/xen/arch/x86/cpu/microcode/core.c
>> +++ b/xen/arch/x86/cpu/microcode/core.c
>> @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long
>> *module_map,
>> return -ENODEV;
>> }
>>
>> - microcode_grab_module(module_map, mbi);
>> -
>> ucode_ops.collect_cpu_info();
>>
>> + /*
>> + * Some hypervisors deliberately report a microcode revision of -1 to
>> + * mean that they will not accept microcode updates. We take the hint
>> + * and ignore the microcode interface in that case.
>> + */
>> + if ( this_cpu(cpu_sig).rev == ~0 )
>> + {
>> + printk(XENLOG_WARNING "Microcode loading disabled due to: %s",
>> + "rev = ~0");
>
> Sadly there now looks to be a newline missing. Easy to add while committing,
> I suppose, and with it added (back)
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Actually, the 2nd string also is indented too deeply; unindenting will
in particular help with line length in the 3rd patch (which isn't to say
that the line's getting too long there, but it also doesn't need to grow
as long as it does).
Jan
|
