[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 9 Aug 2023 13:34:46 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JE+zwnNBEWcZY3KByuvoYBwueGKBwPSlNOUFMVG6wK4=; b=d0AUKmGi3bkUHVtFd6hkTkPolOEZMAjfkMa/fLM1OXIUMXxHa4Czkw+nsQEx8rvEnIfV8JXWIW9tyTXTnmYYkDcQSciBUCsB75aYolZ8vuTRXqtDUunaZ/3ZwWu3idY9mm6hBgVnblBT5ZSMyd1YUsNnjHzkZODIc2gpGgB43QrHxpdgZft0tMaXy/eNUY6kYVITip7QMpDfAmThIP9RfySjxe2I3obN5VO5RNImb8tGPtYIYYfoUCtexcOBUtnzgMg6VMUGiG+kPXusjdq3PCDZIChVWk7ka8ENVNHjQszCCDIOh+dvL4wONJooAzrvDW6z4agUrnJue1lsy9DOZg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpKaMvL0YW0ckNkAGvol/P4igcjU7HmomIgGjPDc1Y8ZTusG/6el1SEBpzA/vaLL05155Y963wMf/GUgNNsVphgpTnHuLfPx6IshKkvHXp3dcXLQf4t6/ZYvAmbOeEvViSQuddcojwiwu2gUqXcvGz5fJFDz605XZlGuhYRp1AQvBi+RbP6hLz6xbvIyyAwv4dS9MUx/DoCWorBusC14kCWIASyHeU4cVQShRAHtvytamLyKUdXSlYSfWgZ1V9qbDwrH/GxrTmoT/O7a7Jxj/g5BHkEJMVikxvfqGf8fvD/vMpFK/oKhbCVxnXNULvq/UjQVwlSYHEUvKC79zVpzuA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 09 Aug 2023 13:35:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZyrEh5sKZJy8ET0extcxfAe4LeK/h9xaA
- Thread-topic: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4
> On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>
> The function 'ioreq_server_max_frames' can be defined static,
> as its only uses are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Makes sense,
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Maybe it’s also better adding this:
Fixes: 9244528955de ("xen/memory: Fix acquire_resource size semantics”)
If the maintainers agree
|
