[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Aug 2023 15:41:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IwLfT/HY8Y+KE1UDEXbyy7Wsk9vEplxTZdEr1YhPpo8=; b=WPSI0Px+6CS+ptK1WjRwPLaMMEaZKuAZ4mF+9OZVe4/KOM+HnWoV0QpgxTd0zjT8SjGA6sAlHH0bL1sfqueDuKnLkK0BCYPuU0eavYx70OmAEjdkUXiYHYjApKRdGKGP9L7F6Ayvnt6XWxVaqrJfxzNvRu1s52ytHkt9PQjlFOp9q9Ahgk+IKqR6vqWayCv3fTsG5TFxyM4xTbsFiWEiMTuab27qpx/Ma7WXzqWLVNnYAIDznPGN/APt4Ud3YwmJLW72dLotzB68+GAQUIIDhRn3ZqFbP2kEeaI8WuJIj+XLVHd6O8kKQpUo3Ss8BZjZK40grJa4n3XnDvq9BQxY3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FL/jKIG07D/7FDLlDlKwU38FCdoXGzcS7emKy4s/PkxNerpnAIkvppPmdIVJRVEwt8+13t5SxmXro974cWiyZOIDzlV7nwp7jnXo7NcN3BtM0ZPyazNDiR1PpRNmXf9Z0vt0/UTuj43JUxl2ghVdydKKWaKjR+8lgciirQE1D2JcygQIcqtv3gg6pcdOOcUFpap5rGQyNUq1GFbIBLV5r0gyiN3sJJ4tqSpzIA1CqnrJebrSags8AMbl8C45GAQlduB+VKRI6FRlb8L4vEK44hNTkOhtGiupmSagQCVzWBBuYYT66QSv5j0mlm5SXuXh3ZlpRj7iQrvA8EcF778qgw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 09 Aug 2023 13:41:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2023 15:34, Luca Fancellu wrote:
>> On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>>
>> The function 'ioreq_server_max_frames' can be defined static,
>> as its only uses are within the same file. This in turn avoids
>> violating Rule 8.4 because no declaration is present.
>>
>> No functional change.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>
> Makes sense,
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> Maybe it’s also better adding this:
> Fixes: 9244528955de ("xen/memory: Fix acquire_resource size semantics”)
>
> If the maintainers agree
I for one agree; in fact I did ask for Fixes: tags throughout this series,
but in the context of another patch. As said there I also think titles and
descriptions want writing differently here.
Jan
|
