[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Aug 2023 09:14:39 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sjyqSozBctvTcsRbGw1xoNDhu+P+lKR13bT9lLYOJ2I=; b=YkhtpaTwTRzc7OgWJ/DPwbfqSHAFpROetCglTmn2xnL5+btz0pNyB/go0kNf26K8HJ8riLIvharHO1dJms5qht89/rCXgCBSDDGOJhToPJgrHXClW+DtQqsURIY3QZ7drI9u5EEfCcEb7U4c3lJujv/2nsl7hUE5Vn7nznczeT44bxx64EwgHA0CaNNmhqPTDDJM7GEaLgfuTREaevfvVfPqEdAKUDcIaUoQxZ3Ng+qvdazOKM7+ChiFMzsfeUtGRirKZWlpOuRtsc75gLZ9Quzr3kjQQlVRFOWjqTVFTHWmzRR1hg6FLaRdYwC9vzm+aMWiVIwrxTiFmAMOjLLa4w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYsyWGyIUgHDX8C3WVkMvNlYawIg3+VKa6YO82MC99vC5AgVGjrOoj0c4ehKLlkA/fkveLApb48XjDJ6clnX0Gnmta3k2x3P/Q+G+Q0bIUrKXbPxzVFTcTul2qsT/j2wBw8UZmCRuLBZcK7misyWrrxcuAA0sNDL23qcGhqldMWAD2HH1yZNEz+c0Z76z4oyoT6vU5QXRLbbYpyrkreoiTYNV/y9eQkpMK2tI0v66fLlGyC3rZyJLnAlIq1y8jSveKygHkGhgtzkWOQTGx9KW7e2Mi/RYQ5o9xt7NqPolxRglrJsf0wkVSCgMyMy8HH9n97tstORfdXgcn/gY2swJQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 14 Aug 2023 07:14:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2023 00:30, Stefano Stabellini wrote:
> On Fri, 11 Aug 2023, Federico Serafini wrote:
>> --- a/xen/include/hypercall-defs.c
>> +++ b/xen/include/hypercall-defs.c
>> @@ -107,11 +107,16 @@ defhandle: physdev_op_compat_t
>> prefix: do PREFIX_hvm PREFIX_compat PREFIX_do_arm
>> physdev_op(int cmd, void *arg)
>>
>> -prefix: do PREFIX_hvm PREFIX_compat
>> +prefix: do PREFIX_hvm
>> #if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
>> grant_table_op(unsigned int cmd, void *uop, unsigned int count)
>> #endif
>>
>> +prefix: PREFIX_compat
>> +#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
>> +grant_table_op(unsigned int cmd, void *cmp_uop, unsigned int count)
>> +#endif
>
> Everything checks out, so:
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> The other changes are uncontroversial. This one about splitting out the
> compat version of grant_table_op is not great. I wonder if it would be
> better to rename cmp_uop to uop in xen/common/compat/grant_table.c. I'll
> let Jan and the others decide I am OK either way.
Would there be anything wrong with instead renaming compat_grant_table_op()'s
respective parameter?
Jan
|
