[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 3/6] x86/vm_event: add missing include
- To: Julien Grall <julien@xxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Aug 2023 09:16:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BwRS2+dFdMXNaE+6d8LOg6DOaiWWw1h97YGxv09qc6w=; b=PpKsTTCcWK/S8ZHeoycjuJ9qS0VMo1SDnBcH5O7qy5PlDsiuve9XYymu79o5/HrdLmc5+O1atFLoLPIxhPeEgEZt8D6mO068elva7QyocOV4lrgKpmg55saNNlTkKWt7qf/ZaFVC2SGQzkGa3Hdq/GzubsRcwteDoBcuvQB+Lp+b9Yl8ab6p9XNib+3pJiJ+YlaJxVhOAflA23ppy/EpUtVOTLG6Y+Gmy1xCcdd+6U/mHZCDmqalZay+JhM4XJRSyKS3KJvb4gC9AyZDTKbwmBZnKCTw+lAdyYYSMNQwFnxOB/6ZuCRtCGs+XYTB64Gwl9l20jDB2Z/hULYwKaP1MQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HoRDwZrpmiEtsJMliq8Q0vdEpKxByJvodeSPj5QjTTh24K0XjKLjmK93IPCCHYPRNUz1Y4A3AhuoAUGngyw1pgM1SRdV9jKojNRnBVMFIaNy1kuGTuLgm5KrWWFiPx+y/YNTsMHDDt6eRnuWne/QrN3lNLok4Xxj6LEJhCFjrGZnDRaUJgRua72QxfcS6Kg6yT2cXQKG4/H1pYOkTaFuD64mCfEHoX5SW/F/pt0wlwXpw7mR0ixL3RNzOdPhZcRL60P+U71bSi/cp0kws8L0CDwfDty4KhWjpDB3VX48YG/5MtfPr0o3ChMF7JhcdLPZEyHK/i/yC1cvlQ8+0MbaMQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, tamas@xxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 14 Aug 2023 07:16:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2023 13:37, Julien Grall wrote:
> On 12/08/2023 10:53, Nicola Vetrini wrote:
>>>> diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c
>>>> index 7027c08a926b..499b6b349d79 100644
>>>> --- a/xen/arch/x86/vm_event.c
>>>> +++ b/xen/arch/x86/vm_event.c
>>>> @@ -20,6 +20,7 @@
>>>>
>>>> #include <xen/sched.h>
>>>> #include <xen/mem_access.h>
>>>> +#include <xen/vm_event.h>
>>>> #include <asm/vm_event.h>
>>>>
>>>> /* Implicitly serialized by the domctl lock. */
>>>
>>> I think the problem here is that ./arch/x86/include/asm/vm_event.h,
>>> differently from ./arch/arm/include/asm/vm_event.h, doesn't #include
>>> <xen/vm_event.h>
>>
>> I see your point. Do you think it would be better to include xen/vm_event.h
>> in asm/vm_event.h for x86 or move the inclusion of xen/vm_event.h for
>> arm to
>> the source file, as done in the patch?
>
> I think it is a bit odd require the C file to include the arch-specific
> header and the common one. It would be better to include only one.
>
> My preference would be to include <asm/...> from <xen/...> and then only
> include the latter in the C file.
+1
Jan
|
