[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 3/6] x86/vm_event: add missing include
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Aug 2023 09:39:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SHMmXQiXK3VPcqOHK5IUv7i4D+GNTUfg4/6TvJQGonQ=; b=TEvI99gufexC/5SubJ+/MQ6hqKUMvXKbuKAwkerTXL9yxCf686bLyAvHysqd7/krGMWJXw8d+TUh6Y6egihAdUtDdZvZC+vfP5yNkMAa5n7i9u20P9DKgc+/WvP1uxePhfKLyOn+Pj2kZww7QU9D4BMGzAnAeOjO1eMUdtXrA9tR7DHjUwFBl5DZD674EuuNbL5wISTnpVMzHBU9TOhKC6ggYBvbWtjw5br/uOxyhYYh8/Pzv6XXAToAh7vX0Esp1kWv0TY12Sp1GvB7sRiPXC/y6xjizHhF3hFO5BzIQHRS8U5oVgektmLpMEeSKmkedbUhhGK3X7SZ6y5n0Y81uQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJ0xV2O0NUjL51cvUAdElafw8lsbKYFm+lbdceLon3qdh2hDGwlyYmdNmKfkEtkmBrJKXcfBj8awxREB7QLa0hjYcl9YLdt3235XTxsWW+GG1w/TBa4rrSKXzFHqZNKsYGi9oNVdf/3JClU0rZRTJRwpgfx+u4BOjGsPzxGzFEir7UpNoomWFh46qZjp8Cw4wRFLVh0OEoEgca0aTqtTOqi9pcziUhmQzhBKAHJ9A4ETUnQOZChQvzw9IXTOXn+9cmvrsY/hSyyR2u3rHgnEBIM8FvzxNMkbaJcnsV4tBWjyMZP1X8Xg17QMot/K5VctjC+26LQ4w1IbWHwQs4KTXg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 14 Aug 2023 07:39:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.08.2023 09:19, Nicola Vetrini wrote:
> The missing header included by this patch provides declarations for
> the functions 'vm_event_{fill_regs,set_registers,monitor_next_interrupt}'
> that are defined in the source file. This also resolves violations
> of MISRA C:2012 Rule 8.4.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Fixes: adc75eba8b15 ("x86/vm_event: consolidate hvm_event_fill_regs and
> p2m_vm_event_fill_regs")
> Fixes: 975efd3baa8d ("introduce VM_EVENT_FLAG_SET_REGISTERS")
> Fixes: 9864841914c2 ("x86/vm_event: add support for
> VM_EVENT_REASON_INTERRUPT")
It's hard to see how it can be three commit here. The oldest one is at
fault, I would say.
Also please remember to Cc maintainers.
Jan
> --- a/xen/arch/x86/vm_event.c
> +++ b/xen/arch/x86/vm_event.c
> @@ -20,6 +20,7 @@
>
> #include <xen/sched.h>
> #include <xen/mem_access.h>
> +#include <xen/vm_event.h>
> #include <asm/vm_event.h>
>
> /* Implicitly serialized by the domctl lock. */
|
