Re: [PATCH] IOMMU/x86: fix build with old gcc after IO-APIC RTE changes

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 17/08/2023 07:39, Jan Beulich wrote:
> On 16.08.2023 18:57, Julien Grall wrote:
> > On 16/08/2023 10:51, Jan Beulich wrote:
> > > Old gcc won't cope with initializers involving unnamed struct/union
> > Can you specify the newest version of GCC that breaks? This would help
> > to reproduce your problem in case someone complain about this change.
> I can't, without actually putting in effort to find out. I'm observing
> these problems with 4.3.x iirc.
You are proving my point. :) If you can't already remember which version 
of GCC was breaking. How can you expect someone in a few months time to 
figure out why this was added and whether and it can reworked differently?
>  And of course this isn't the first such
> change, and I don't think we ever bothered writing down precise version
> boundaries in any of the commits.
I am not looking at a precise boundary. What I meant by the 'newest' is 
the newest one you try.
With 'old', it is not clear what this really mean. For instance, 
technically the previous GCC version is already old. So a bit more 
information about the GCC version you tried on would be useful.
Cheers,

--
Julien Grall