Re: [PATCH] IOMMU/x86: fix build with old gcc after IO-APIC RTE changes

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.08.2023 09:06, Julien Grall wrote:
> On 17/08/2023 07:39, Jan Beulich wrote:
>> On 16.08.2023 18:57, Julien Grall wrote:
>>> On 16/08/2023 10:51, Jan Beulich wrote:
>>>> Old gcc won't cope with initializers involving unnamed struct/union
>>>
>>> Can you specify the newest version of GCC that breaks? This would help
>>> to reproduce your problem in case someone complain about this change.
>>
>> I can't, without actually putting in effort to find out. I'm observing
>> these problems with 4.3.x iirc.
> 
> You are proving my point. :) If you can't already remember which version 
> of GCC was breaking. How can you expect someone in a few months time to 
> figure out why this was added and whether and it can reworked differently?

Well, I know for sure that this doesn't work with the version recorded in
./README. Imo that's sufficient to justify submitting patches like this,
and without going into version details. Once that baseline version is
bumped, much more than just this code can and wants to be re-evaluated,
by simply trying with the then-lowest supported version (which imo really
ought to be part of what is tested in CI, to not always leave it to me to
find and fix such issues).

>>  And of course this isn't the first such
>> change, and I don't think we ever bothered writing down precise version
>> boundaries in any of the commits.
> 
> I am not looking at a precise boundary. What I meant by the 'newest' is 
> the newest one you try.

Okay, that's slightly different and hence possible to record. I can do
so here just to please you, but as per above I don't think that ought to
be a requirement (and as said earlier it also hasn't been in the past).

> With 'old', it is not clear what this really mean. For instance, 
> technically the previous GCC version is already old. So a bit more 
> information about the GCC version you tried on would be useful.

Hmm, no, that's not really my interpretation of "old".

Jan