[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/13] xen/arm64: prepare for moving MMU related code from head.S
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 21 Aug 2023 08:54:19 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tT+Iwelypa5jSG7/ijsvg7irY2o5+ZrC4sNzUyV+gmM=; b=nHy9yb+id5idXI4rmUvThobco6ojQzakG5el8mSxzvnXZfEQAM7p4tp55VtRfyPiaS0vMcc56r09KwEECcO9wFH9VrryTZt15VgNjqAgQtNRyn9+WiQrhtRYPzFRLg3dqlTXoomlfCcC3gxW9OZ/KbTPeKu/ynWhdSNHPZgAwNTsGmh1uyLgJ5XEiDynbCuMm1E9dRw+3+mVQlKwXHVrj/CsJuwt0w1aud6IfmFK8V8I8p2h8wT2hZwsPuYvyU051EAJ/z/zhlcZZyM680Mi6t/oDtk2lwODctfRgxr/AVNyod/qYXPrRwhNT4iiyx6PHVEOokLbxj0kyqFXNoag1w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPxqoNShdTS+izJpwsLU0KNrJ5zDjG48PdY/4K8HzsRJWxA5e/Gw6a4eYgepDy+O021lyPbAFsgfFjoh9bFtx2vlA+AWAyJBHBi5pfmxW0Yw2XuOncgxfkaYmd100Fm0JwUbDfCKjQszp0oFkGzw77V99/+qemehnlNMIPR23yhRsoyQIk4MtauI6SjgsAw0StC1GN2edY/XPEhmBTBR3p6GC28g7qQGL18ltN2ayTXp7co0aU9w/Kprse6UyYj2jEijXMI4gvQwhLo/h7ZELZAY0X3MNyGD8FKVOMLLZH6/tnoh0bdQibXsfkiiPidx9uy8HOt+QEf4o/4U0OujFw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Mon, 21 Aug 2023 08:54:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZzmd24OlLZqf0JE+rdrv6VmJecK/0eo+AgAACuQA=
- Thread-topic: [PATCH v5 03/13] xen/arm64: prepare for moving MMU related code from head.S
Hi Julien,
> On Aug 21, 2023, at 16:44, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 14/08/2023 05:25, Henry Wang wrote:
>> From: Wei Chen <wei.chen@xxxxxxx>
>> We want to reuse head.S for MPU systems, but there are some
>> code are implemented for MMU systems only. We will move such
>> code to another MMU specific file. But before that we will
>> do some indentations fix in this patch to make them be easier
>> for reviewing:
>> 1. Fix the indentations and incorrect style of code comments.
>> 2. Fix the indentations for .text.header section.
>> 3. Rename puts() to asm_puts() for global export
>> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
>> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>> Reviewed-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
>> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Is this patch depends on the first two? If not, I will commit it before v6.
Good point, no this patch is independent from the first two. Also I just
tested applying this patch on top of staging and building with and without
Earlyprintk. Xen and Dom0 boot fine on FVP for both cases.
So please commit this patch if you have time. Thanks!
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
