Re: [PATCH v5 03/13] xen/arm64: prepare for moving MMU related code from head.S

[Julien Grall <julien@xxxxxxx>]

Hi Henry,

On 21/08/2023 09:54, Henry Wang wrote:
> > On Aug 21, 2023, at 16:44, Julien Grall <julien@xxxxxxx> wrote:
> > On 14/08/2023 05:25, Henry Wang wrote:
> > > From: Wei Chen <wei.chen@xxxxxxx>
> > > We want to reuse head.S for MPU systems, but there are some
> > > code are implemented for MMU systems only. We will move such
> > > code to another MMU specific file. But before that we will
> > > do some indentations fix in this patch to make them be easier
> > > for reviewing:
> > > 1. Fix the indentations and incorrect style of code comments.
> > > 2. Fix the indentations for .text.header section.
> > > 3. Rename puts() to asm_puts() for global export
> > > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > > Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> > > Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> > > Reviewed-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> > > Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> > Is this patch depends on the first two? If not, I will commit it before v6.
> Good point, no this patch is independent from the first two. Also I just
> tested applying this patch on top of staging and building with and without
> Earlyprintk. Xen and Dom0 boot fine on FVP for both cases.
Thanks for confirming. It is now ...

> So please commit this patch if you have time. Thanks!
... committed.

Cheers,

--
Julien Grall