[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] x86: Fix calculation of %dr6/7 reserved bits
- To: Jinoh Kang <jinoh.kang.kr@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 22 Aug 2023 16:54:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CIfo4HV8aFKQpwe/tio0Wh8AgzZFvgpGq+yW8M32Un4=; b=MBb68NNQqECIJeBFK3Lvp7MX3oTnZQhexjJj5QxVvcPuu2tMIC/GZf7eKFG+inrni9PP2yRQsP9G7WKONMlQTL7KnJXLnJr0Hys3XLp0h2kSPfS3g5evR62zjaZu9lDlOXgtu2PcJfjmVyyD1FuxB+uteJfwtTrzfWleK3GJAaiEMWGzk3Ck1Ba6mWVYF6qWe09U67aBpNmIWwKkNbEjPbc6cqbh9QPOIFJ+rcXR492FcR8IOg0BW70sAsGLGyOz7HKPgqVKcjGIvA6hSJMhtopWnnTAdzAQvnE3Cux0t+3Wn3mG9inJ9RgTPIqITPtLHcw887ZriJ+mRDry/sNtqA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6tVTRkgkqNvH5j4O8b8NUIKooml1abV3VSEFHalrTW/yASMn2g6qi//1li1XyZsfRYKMBnXXAcChvjnOaexjyf4K6Mc0nh3VOrXYJwTNi4dOzf/TuZW9W8xXsXCktjmPiE0Pl54xpiiY5b3h0rvlb8IhhO+Uazfy3s8szUdjkMaVzXJEhr/7VUyOMFeGh8IFqgDXK427gkgh7b9/Qk7xYsK3WRXANhCnR2wZd8nCtnPOhhglpAJZRJg/MS/tqN0HFfoXTPG7IxBNOeLH1hHFygmqit2OeD+QSr+bnkXVqtHWvZEsI+YH5+Ru06RP9P1OIqKeLlFPFwnoEdR82ul4A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 22 Aug 2023 14:55:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.08.2023 18:12, Jinoh Kang wrote:
> On 8/22/23 00:56, Jinoh Kang wrote:
>> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>
>> The reserved bit calculations for %dr6 and %dr7 depend on whether the VM has
>> the Restricted Transnational Memory feature available.
>
> s/Transnational/Transactional/.
>
> It was in the original review, but I missed the change. Apologies.
But that's not the only change that was requested back then. There was
one aspect Andrew didn't like, so leaving that part as is would be
fine. But for the items he didn't further respond to, I'd expect a
re-submission to take care of them. Plus, if you didn't address
anything, you would want to (a) mention that and (b) take Roger's R-b
that was provided at the time (unless of course re-basing was resulting
in massive changes).
As I expect the same to be the case for the other patches, I'm not sure
it's worth looking at them (again).
Jan
|
