[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] x86: Fix calculation of %dr6/7 reserved bits



On 8/22/23 23:54, Jan Beulich wrote:
> On 21.08.2023 18:12, Jinoh Kang wrote:
>> On 8/22/23 00:56, Jinoh Kang wrote:
>>> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>
>>> The reserved bit calculations for %dr6 and %dr7 depend on whether the VM has
>>> the Restricted Transnational Memory feature available.
>>
>> s/Transnational/Transactional/.
>>
>> It was in the original review, but I missed the change.  Apologies.
> 
> But that's not the only change that was requested back then. There was
> one aspect Andrew didn't like, so leaving that part as is would be
> fine. But for the items he didn't further respond to, I'd expect a
> re-submission to take care of them. Plus, if you didn't address
> anything, you would want to (a) mention that

Right.  I'll try to address the rest and provide rationale for those that
aren't feasible.

> and (b) take Roger's R-b
> that was provided at the time (unless of course re-basing was resulting
> in massive changes).

There were many changes, some arguably cosmetic and some not-so-syntactic
ones.  Quite a long time has been passed, so I was unsure if the R-b's
held up to the present moment.

> 
> As I expect the same to be the case for the other patches, I'm not sure
> it's worth looking at them (again).

ACK.  Please consider this patchset withdrawn.

> 
> Jan

-- 
Sincerely,
Jinoh Kang




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.