[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock
- To: Julien Grall <julien@xxxxxxx>
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Thu, 24 Aug 2023 21:44:48 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aP44Rz8RZDYYx6gs70yg7+oGb2YlKeE1DZXX9oWyySs=; b=bqu2loQVwIlTXjgJHW2AT+j5vJJanm16OXwaHY82yK7aIN6w5ziA29ucH5nx0Z2cgxdVd1qmAm9CD/uRPMd1d0ge8+fmivL2FT/l1PLsbNGhMgh2aA6tWo6YEhFw3wkoSyOaVfHo/bTDNVLqNV7HEltxS59SY+qya1UK4PoZSYHal9x44+xVa3LEUrBGSAXNKPjLHKEzxSRM57RxZkufQdG4gSOSHf5hjHMwkUJtH0CUEA0d/PAOVP0PxM1G435o2B/sJadvY+ojdyhKzMUekFD6snVRFmnBPwjcaUIX1G9qSgaB3UImb+uyipMC+/pxDXCOwCNjsGKNnDlpAbA20A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=De830zXFSon0qjbFNQdFNK5mDO1n+g4+Dcb6O8QL5IyG9e4PNpoUXbjT5ToD+Zrj+VTOrgDqtxxhwSrxEwrkWIHEjRpxN4rKkEyYfkNfcFTgOXxkeCgBYE4IRb3zjfAcShBwX2LzylahJiJ9zyQKbORBGUihxmbQbmHUut6fH0+zEjsrKOQh1ImJuogo/zZTBWTa2BbML9i9H4S2X9OairnqpdxqlJ6to4n6o0ibWYKHkwbeJaApE9/5JXX51Vv1z+DOFnIGLOma03BSBFo0PXnolLFv4NsuocTjKoC+1J71s7uK23d3WJyLVxsXze3cwPPL/hQXV5E18Xi3jXSjvQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, michal.orzel@xxxxxxx, sstabellini@xxxxxxxxxx, jbeulich@xxxxxxxx
- Delivery-date: Fri, 25 Aug 2023 04:45:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On Tue, Aug 22, 2023 at 08:47:10PM +0100, Julien Grall wrote:
> Hi Vikram,
>
> On 19/08/2023 01:28, Vikram Garhwal wrote:
> > Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access
> > to add/remove/assign/deassign.
> > With addition of dynamic programming feature(follow-up patches in this
> > series),
>
> Typo: missing space before '('.
>
> > this function can be concurrently access by pci device assign/deassign and
> > also
>
> I couldn't find any use of this function in the PCI code. So are you talking
> about not yet upstreamed patches?
So, this assign and deassign is also used by pci-assignable-add from xl which
"Make a device assignable for pci-passthru"
>
> Also, typo: s/access/accessed/
>
> > by dynamic node add/remove using device tree overlays.
> >
> > Signed-off-by: Vikram Garhwal <vikram.garhwal@xxxxxxx>
> > Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> > Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> The code itself looks good to me. So I will provide my reviewed-by tag once
> my question about the commit message is answered.
>
> Cheers,
>
> --
> Julien Grall
|
