[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock





On 25/08/2023 05:44, Vikram Garhwal wrote:
Hi Julien,
On Tue, Aug 22, 2023 at 08:47:10PM +0100, Julien Grall wrote:
Hi Vikram,

On 19/08/2023 01:28, Vikram Garhwal wrote:
Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access
to add/remove/assign/deassign.
With addition of dynamic programming feature(follow-up patches in this series),

Typo: missing space before '('.

this function can be concurrently access by pci device assign/deassign and also

I couldn't find any use of this function in the PCI code. So are you talking
about not yet upstreamed patches?
So, this assign and deassign is also used by pci-assignable-add from xl which
"Make a device assignable for pci-passthru"

Hmmm... But this is not something we currently support on Arm and in fact this is not plumbed. So please remove any reference to PCI because this is misleading.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.