Re: [XEN PATCH] ioreq: include arch-specific ioreq header in <xen/ioreq.h>

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 25 Aug 2023, Nicola Vetrini wrote:
> The common header file for ioreq should include the arch-specific one.
> This also addresses violations of MISRA C:2012 Rule 8.4 caused by the missing
> inclusion of <asm/ioreq.h> in the arm implementation file.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
> - The deleted includes are therefore no longer necessary, since
>  <xen/ioreq.h> is sufficient.
> - The functions (possibly) missing a visible declaration prior to their 
> definition
>   currently are 'handle_ioserv' and 'try_fwd_ioserv'
> ---
>  xen/arch/arm/io.c       | 1 -
>  xen/common/ioreq.c      | 1 -
>  xen/include/xen/ioreq.h | 1 +
>  3 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> index 96c740d5636c..13ae1fed5718 100644
> --- a/xen/arch/arm/io.c
> +++ b/xen/arch/arm/io.c
> @@ -14,7 +14,6 @@
>  #include <xen/sort.h>
>  #include <asm/cpuerrata.h>
>  #include <asm/current.h>
> -#include <asm/ioreq.h>
>  #include <asm/mmio.h>
>  #include <asm/traps.h>
> 
> diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c
> index 7cb717f7a2a4..bde1a1f4eaa1 100644
> --- a/xen/common/ioreq.c
> +++ b/xen/common/ioreq.c
> @@ -28,7 +28,6 @@
>  #include <xen/trace.h>
> 
>  #include <asm/guest_atomics.h>
> -#include <asm/ioreq.h>
> 
>  #include <public/hvm/ioreq.h>
>  #include <public/hvm/params.h>
> diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h
> index a26614d331e3..d85477c665e9 100644
> --- a/xen/include/xen/ioreq.h
> +++ b/xen/include/xen/ioreq.h
> @@ -20,6 +20,7 @@
>  #define __XEN_IOREQ_H__
> 
>  #include <xen/sched.h>
> +#include <asm/ioreq.h>
> 
>  #include <public/hvm/dm_op.h>
> 
> --
> 2.34.1
>