[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] ioreq: include arch-specific ioreq header in <xen/ioreq.h>
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Aug 2023 09:59:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E3B3TcCNXq6pGw9ceHzzqKqwai7vuBf4WPWv6cGiZWQ=; b=DEAaPueG/7LJLEDhyfya5kwajVWnoP2C50k+0zVqzML+h7pr2MO58L0w2PlhWinla5BG3aBxkClLf2tArODkF3J/giOlOTThhTT7XMSi4NWtlTl6JLJ2Xk0LLnCe3R0UKTN4rH3H+ZD3mReZfSo8oNkjm01r3oqLg7yW1smn1hpRopNztRCRc/E63Ttbu4WMmwwEG1y9QUdHUoue+Gobf+mQWlwdrAgZkN22ti8UskO9dApItCzLXW8v2lezAxg2f18rzwS6WWUGixvJBd+utFkO9XcZ/P1GYh73YY/xE78pdYwikstF4oH2iGw27gjmJj51HC+wCPkgVvQTN0tOCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gO3YWZb+X6N1DvFygljEcaVFZJ1mT/ksAew6VnTnf+BhQiPjobDEgpzlNyWdEMmrDbBsp3y60zr79CIfSNOtzhxrSyKVXsdJ17Fd5Qrnyt01QgWhFRK6RKwwms1hZ+21uMNmNDejFGMg66+/+gBILUq4jeOa5NztJGlo4Pip33FZjLoyoJDBKv3FyUAv5VRKmhNmRdvDvYnWcz6l9nUXSHwg4mZcyN0HJrZmMf46LRO4FQXhbA0P3LTG6V7mGM0xL3Tjbo7WVqJujx82fDVgTOF72S7mHGfaOMwv6P8i9WjzlTpb15Y5JW1vpzAhq+EEbaMQMsSmYowSQKKdnT33+Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 28 Aug 2023 07:59:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.08.2023 17:02, Nicola Vetrini wrote:
> The common header file for ioreq should include the arch-specific one.
To be honest I'm not convinced of "should" here. There are two aspects
to consider: On one hand it is good practice to do what you say. Otoh it
introduces a needless dependency, and it'll require new arch-es (RISC-V,
PPC at present) to introduce another dummy header just to satisfy the
xen/ioreq.h use in common/memory.c. Therefore, _if_ we want to go this
route, besides a wording change here I think ...
> --- a/xen/include/xen/ioreq.h
> +++ b/xen/include/xen/ioreq.h
> @@ -20,6 +20,7 @@
> #define __XEN_IOREQ_H__
>
> #include <xen/sched.h>
> +#include <asm/ioreq.h>
... this #include wants to be conditional upon CONFIG_IOREQ_SERVER being
defined. (I'm actually surprised that there's no respective #ifdef in
that header, meaning types defined there are available even when the
functionality was turned off.)
Jan
|
