[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 28 Aug 2023 01:53:15 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=suUPsCTViDXtxAyymCfoXUkrtE0Idkgmt9/T8BonYXg=; b=MrFNubq9atzMsSh2D+wgqpxfGreiyp+9VEbcxUjyJRa4E+PHIcnRpW9VOkce7W8GvipkaCFDdS0OO3Y0k55a0lCMg9eBVMuazqttuUxjPzgLEI4Vq1OMyQ5OZofxapFhGux+ZCNYZteI0lUSbx7BDdpgnRyX087V6OXMsWKy3i+2qZzv1QbKVwTGpwTyY6DHS7LijSoHcmkdYih3AHR+FCXZP48WQpoQMpyKFht3iXgRneZXbEZ8P3AGxhg9THJVX1w4jl+y4Ci9728MrGWrH4F3H3VC/pwNShUXkx3GCzJbbU9IyLpenWwE+KNABL033e32q1aMB2cBREmpLaJaUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QB2fK0TCqO/GBDkPKkUWMfZ9ke49BBIcLfY7XHzjXmO/XnvdY3shA2Ape0yNWwAZSMvFTZlbg+nCbocFHi6KAFVyFGspNgaFNtz3DeYoC5CVxT1NhkfNHjgft5v8VbvSlv1NTA5grzC8cX5qXv+K0dgAQ/NVYoCmp8XAA7pwyotuQVPNSV0MjSS8Eao7aFlc39GNPb6m6P+hawqiQ9PackL9osEXj1GAf+GuKjYicArBG1ERNYb3S6hLD3B7bd/qDNZyLBoacwQNliyuDHoyfwQVz3mFwW8z4woXLAx3B0hC9amgQpDWTGUpLJ5jRjK7EWgOszJZTj0Hpq3CDOSaaw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 28 Aug 2023 01:53:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ1yqggX5G5+V08E6Qji7ACNl+qa/+9m4A
- Thread-topic: [XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type
Hi Vikram,
> On Aug 25, 2023, at 16:02, Vikram Garhwal <vikram.garhwal@xxxxxxx> wrote:
>
> +
> +/*
> + * handle_device_interrupts retrieves the interrupts configuration from
> + * a device tree node and maps those interrupts to the target domain.
> + *
> + * Returns:
> + * < 0 error
> + * 0 success
> + */
> +int handle_device_interrupts(struct domain *d,
> + struct dt_device_node *dev,
> + bool need_mapping)
I think you missed one of Julien’s comment in v9 that this function is
suggested to be renamed to "map_device_irqs_to_domain" [1].
[1]
https://lore.kernel.org/xen-devel/5908b638-f436-4060-a426-9839fc563c63@xxxxxxx/
Kind regards,
Henry
|
