[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Mon, 28 Aug 2023 09:21:50 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7SSjuE/GCajdaTJNp4yiC3EW6+InoAD5ApDD+ZM2ZF4=; b=QKns76NaTudywW0vkUnC4imJWkTFP1x23bU+Vtr/nLFKge1km8FtISgwdLpePa5r0B5/lck6D/U0KOqlLlnc2gw2rRLBrxCktTEW0IvV+myzLq25SLjCdvI0H543QNzb9AHbcuA+bWZAUPwsY19Xs790aAfVChwN4tn7ZR2bv5OiunSYiX6Fa9/xCsecizaiT6HcqQyd51ss8Ghcp7LQcBEYFfDow4pu/m3Bll9Y8jOECKe2gJUTj754sm+mgRHQFflJ2ThDBvDeLQ0dZ9n5CmF0zhyNTmY2Ey8A1S8DYaHgnxkbDoKUXd6xB2mFT1QKzcUl+MfQjnO6tcuVdiGtXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFsotpgG1RY7dKtC27FqI3bvo7MU5hyUGJKmMdtKsVKzLYiUvhQh1y/xi4pSH9az/rNSpuYwt4cSwCtY8TaNIKx++suKG7w93QkEoYqAxCe44D1Mqj9m3WgtXygQ+TDAR/NbfzA3ekxmp9GLvi67U3S8BUMKfpRPVExNLOONu0LKFYbw1pImx6m+fEzfqkqeydjza2um91x0XAS0Yhx7l3zErSsjDW+6l2M1STpqmnFn/ayfZIbSRbke4E3HqVVuwVLLnyEDiyjMtYR+nSqBD9C981XTQqFc/mlJ9bC0GFvXLbbOhJ++2djYB+QxjjnxXI/G52pdSYX3kR+p0I2mKg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 28 Aug 2023 16:22:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Henry,
On Mon, Aug 28, 2023 at 01:53:15AM +0000, Henry Wang wrote:
> Hi Vikram,
>
> > On Aug 25, 2023, at 16:02, Vikram Garhwal <vikram.garhwal@xxxxxxx> wrote:
> >
> > +
> > +/*
> > + * handle_device_interrupts retrieves the interrupts configuration from
> > + * a device tree node and maps those interrupts to the target domain.
> > + *
> > + * Returns:
> > + * < 0 error
> > + * 0 success
> > + */
> > +int handle_device_interrupts(struct domain *d,
> > + struct dt_device_node *dev,
> > + bool need_mapping)
>
> I think you missed one of Julien’s comment in v9 that this function is
> suggested to be renamed to "map_device_irqs_to_domain" [1].
>
I sent v10 bit early. I will do the renaming in v11.
Thanks,
Vikram
> [1]
> https://lore.kernel.org/xen-devel/5908b638-f436-4060-a426-9839fc563c63@xxxxxxx/
>
> Kind regards,
> Henry
>
|
