[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/irq: fix reporting of spurious i8259 interrupts
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Aug 2023 18:13:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hcb8Z7PPC9Fxf1bYcSW64of61eCT5EJ6bq4tWZPQP0s=; b=cWmiopd+c1EUHe/1E5WcjlI8MT5vYp3GczBh4aFdmZD9qWbyBWcNqGe2nlLGAHqrQVXex426tTyDYBwghlYR86ukiaJHrl9/90tlbJ6x5mjVxYWEtRnDiLopyJ8kjCOTG6OMJwCUEM/iVE3npmcYGQqvF94AhlaBf07LW0wypTrM0/SrW7k/vgeNRWt11NZ+HDRCOovqRAr+FaRcE8uNydJB1IlEqaGEOBlOv6buUfN+l9HGZIM1ONN1AWSFeFI8aEXO7y9WhfPDcnGJioPehiDCBihH5RmJNwv8DX2JgLd2XKuFALD2SlrQohn4VDd5d9nDfhDaRiyNuFYbJsameA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjRO/9gc1GrEsVTgCg6ENaEJMwMFZ8cnYmybqLs4+HL7fry98DXru5fJ86pqV31L+WngX+veN60U2/XtxvtLFuafksw2uk5znF/2Vfc35KrMeooDWLMi8gmIHAU43M0KuqvZxhW0HyR1UV1zNmhj7INWcToMXEJwXgmHAuqyDqiMsTvpWqHRUivSlqH8NlxFpDJsrsLuh0IEjFaCultpM2en5CoUL7m941Nw4BdpAXquzQWVHFuXMhDMHMDGEfyYzxlkbHkJzOnMH/AJVaGJ3eKFKX9m5fRUnXdVp5vXg5smeVM0sk12iZ+oD4ifm7YtABM9VGqu4NMJsFDpkwO7OA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 28 Aug 2023 16:14:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.08.2023 12:14, Roger Pau Monne wrote:
> The return value of bogus_8259A_irq() is wrong: the function will
> return `true` when the IRQ is real and `false` when it's a spurious
> IRQ. This causes the "No irq handler for vector ..." message in
> do_IRQ() to be printed for spurious i8259 interrupts which is not
> intended (and not helpful).
>
> Fix by inverting the return value of bogus_8259A_irq().
>
> Fixes: 132906348a14 ('x86/i8259: Handle bogus spurious interrupts more
> quietly')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
