[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] x86/irq: fix reporting of spurious i8259 interrupts
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Mon, 28 Aug 2023 12:14:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5irB92Gz/kcvpAShOyJkwSI1E6gMkky+BAEgmvv+xlQ=; b=QpbYogUfCe5s2GI6tgvKg+LMWOo8wbAwdFnxOcoOKpxroTGdInKqWPSXaSUjYER9Uk4SNUtfDT+kZp7brkWfqgPC1GoPXDimjdKfXcPmDeBH9R8e2hbLZvPyNptY/2wtcsLihY5seqzmIy6dVGDjyw9F47FFBpw9IbcofYFG3U9jp7HVPoM80FMxRYIkKrWxTQM3fqBTH/LSGPgU1cTw2lYjA2BJUqET1Izl+MH6RvOJZQydrpP3fZg+AVfl8oxDG6LHgtHfGPlCb/k+vIUzJAbrByaT7wv99OHQuksDWJAhq8DZQ0YJlAb2FgPXJArw0dDS6/RLeSIHqxMoXT9VMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5wkLuybbZLGFaUfNlqU4tNuTpMC3Po3DPncBaCQD2zDmFCg7n6Zzh5nS6NjX7E3kiKeXWtgUcKYjMBPaM+AjI/FxI/ggAuw42iZdjS7a23QDO8nVJqBhAp+B1ANUK7J6mvHlFoXtvaF4u7LaphrkO5JovJlUkO0C0nI5RIIGAqCSmJL6pVIQj8gcTd7SHVn12Hdompy6+wonPjpeNLtI7ARoBWN7yPwCnbE01ow49g0CV4KWAFnGPUsHVrQnlgEkByYDR3T+C57Bk5SD/ea5B0N/5TYddnD/OWMyFyW2EmF8BS5QK3fQ7zvM0IK3H6Fo11hfD6AmkuLvXQCf85sWg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 28 Aug 2023 10:14:53 +0000
- Ironport-data: A9a23:2gsgRqt+1LAeFXxUWI3YFGFEl+fnVHBfMUV32f8akzHdYApBsoF/q tZmKTyCPaqPYzPyf9ogYIi+9hsB7ZPTx9JjSAo9rCkyFHhD+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4lv0gnRkPaoQ5A+ExyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwNQ4fbTen1seNx6+HbNl0tsEpa8+6I9ZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60bou9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAdNPTOLipqYCbFu74ksdJiw7a1SBgfSTtGe0d9tmO XAs9X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM08SCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptPl8Ic6i0uWSs45SfDkyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU=
- Ironport-hdrordr: A9a23:aWvuzqASgG5Z88flHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The return value of bogus_8259A_irq() is wrong: the function will
return `true` when the IRQ is real and `false` when it's a spurious
IRQ. This causes the "No irq handler for vector ..." message in
do_IRQ() to be printed for spurious i8259 interrupts which is not
intended (and not helpful).
Fix by inverting the return value of bogus_8259A_irq().
Fixes: 132906348a14 ('x86/i8259: Handle bogus spurious interrupts more quietly')
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
xen/arch/x86/i8259.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c
index 6b35be10f09a..ed9f55abe51e 100644
--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -37,7 +37,7 @@ static bool _mask_and_ack_8259A_irq(unsigned int irq);
bool bogus_8259A_irq(unsigned int irq)
{
- return _mask_and_ack_8259A_irq(irq);
+ return !_mask_and_ack_8259A_irq(irq);
}
static void cf_check mask_and_ack_8259A_irq(struct irq_desc *desc)
--
2.41.0
|
