[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 01/13] misra: add deviation for headers that explicitly avoid guards


  • To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, sstabellini@xxxxxxxxxx
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 29 Aug 2023 08:33:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wraxawlFXa4UDAs47ZVS3qMRmmEP8Nfh6c5M63BYFV0=; b=RDPAyuixwL6AiBSczfBLnVvvi1XO2AaxIolm0ChiXY83TStMwXJIUPZEe0r+mI39Ov5KikYvLyRwqEeOg2vDNEtU2NeCSntqfmXjENL6o2PGCVVcMAxHj4XFd38WJjFJM+5LJUw4YiotaDbgCZrPvnm3wWimaYrUHtOhKy/hJTrev3kVlpaUD0AJsJ8sHwaRusCh/y/j1X67FL9fRHCAqmBO0PCQNwecRQUW9KKPedM7ZqDTjkeGYo4Sx8ZQaX4JrNwgbtLvs5mniDg2eICN8uRkcC1s699hhsDT57S5kSD44R7jtD5amabz6grkNDHCpJnp9AvM5NmlYdlHJgfgug==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KU760dnonwk7a1wR64d4XX+lp8rTJ72GrssphIvH0IUNTAYt5Ehi8c/j34BdrDV64cyyXjLOvZAG3frdlJtQewXM3aGn0yfGmcDXhAPPvHrztNwVWSL/TRPxTZdQ2/QXDGLZjVUoTYIdt4LUDZ8ogeKjKXJeVid174Sjk6+0irYMfRCWDNY8XVYp3+uhmpNcdzAy6z6AmqR8E/532HGxxFTpHKoqWa8FcEtSZGd5G9cPvW4/trwaIDIWPaubGy1rcIMkgzbOdpwcJiy8i/88xZRmMhZ/GNk4LSZyR2naM6dBnxJOe89gJFRdWLSb5+qO4c4XJqSaAtu2G2+OcdNtPg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: consulting@xxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 29 Aug 2023 06:33:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.08.2023 15:19, Simone Ballarin wrote:
> --- a/docs/misra/rules.rst
> +++ b/docs/misra/rules.rst
> @@ -60,7 +60,8 @@ maintainers if you want to suggest a change.
>       - Precautions shall be taken in order to prevent the contents of a
>         header file being included more than once
>       - Files that are intended to be included more than once do not need to
> -       conform to the directive
> +       conform to the directive. Files that explicitly avoid inclusion guards
> +       under specific circumstances do not need to conform the directive.

Nit: There's a "to" missing near the end of the added sentence. Can likely
be taken care of while committing, since Stefano has already ack-ed this,
but I'd like to still raise the question of the utility of this statement:
How is one to know whether omission of guards is intentional?

Jan





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.