[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 02/13] automation/eclair: add text-based deviation for empty headers
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, sstabellini@xxxxxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 29 Aug 2023 08:35:48 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zwy0CeFFkK58EQXVD1mrifDsiarmvJe0e6qsjXFu358=; b=V7RxHJ0xYDf5N3adGM0S0mcEln0s/ovWNto2/m/8XSt5JPke8PpmCBZxa7uqNXwr1iH/lNbvkjDH+qc4l57AZcqAh5otKR4HZdkWBJUCSz0CsYRzzN7aqq0BwhskmHfm59leiD3V03oecyGK8if1NY+FMfRxjqBcQIiUqHiH7lna4HWiA/aGhf0FqAu2rFWCxfZ+OT9byC9GuDAfD7WNfOEorJLQvGX7vp4W5aJYRaF+bKyu0xPg6SHEmE6H0522xyYvle7/Wv4XdgwM9gB+uUJXgW6pnwv7LdlvcuWX6dSBILrk/x9gjp5V4K4ME2WysjCszZe6cOeWOa9E+mCXxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lX4YFRZJo23K4kkwwoKYH4j1X2f6AxuTgw9/O4SCK/SFh1UnFnjKbvm8JjR1HegOB4hZSbonXLE70ZpyD1Lj0bYTKA5+j4nA+cezqkrW438A8ksE9G+CNMLF5ADhlWXgkRqqmiV7Nqi2DxOXBa4t7DeXoWIl6mCGjWjQoSjSeLQgKd+861G84lk3g9zxBh8a8UfxO897ESD7+1ow9aDiM17jL2AZu1NfagLvGmOcWUn65wRM3z/o1gc0nGtY/3AOW/lpGv2XnzJwxZVTzmraBtPmbr3BX+a4H1SGJV4mBdubU2pmp7EVTEKziPJbLbWXgbC9rEj+mGNBTO44v9J8GA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 29 Aug 2023 06:36:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.08.2023 15:19, Simone Ballarin wrote:
> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl
> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
> @@ -80,6 +80,7 @@ inline functions."
>
> -doc_begin="This header file is autogenerated or empty, therefore it poses no
> risk if included more than once."
While unrelated to, the change at hand, I still have a question on this:
How come it is deemed universally safe to multi-include generated headers.
I would have said that whether that's safe depends on the nature of the
generated code in the header. Only truly empty ones are uniformly safe to
include any number of times.
Jan
> +-config=MC3R1.D4.10,reports+={safe, "first_area(text(^/\\* empty \\*/$,
> begin-1))"}
> -file_tag+={empty_header, "^xen/arch/arm/efi/runtime\\.h$"}
> -file_tag+={autogen_headers,
> "^xen/include/xen/compile\\.h$||^xen/include/generated/autoconf.h$||^xen/include/xen/hypercall-defs.h$"}
> -config=MC3R1.D4.10,reports+={safe,
> "all_area(all_loc(file(empty_header||autogen_headers)))"}
|
