[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 4 Sep 2023 13:42:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=agG9ptatKdCvR+p02190YvNp1Ai7bkxLcXwFOTCqJQE=; b=ldc7rSX48YIfGpgSENqPpHvVUnenvRgTYC3Dl5UgITWfgJim1GU+B6oLEJHxarWu3HY+922AYpCw0pXbB/j/DFW3QlKn0KKNg43lZ5/JDGs21CBKYEmpgeHkLWrfa9zvj1N6CD1o9LWWSJJ3Uv8YUZf/dLTsIrfDrGNOmY79g4dkXXyolKVw1q0V3fy9AIHiFDkySu2zskDu9Qa+SrA5vjMggDDbvN54slRHZHDQGOMwkpLhHMQ0Y2fSC6dZxJXeNbNZ52LQwDadyyOUWbMkCy2zXXGbqW77m4vbNDE4bhzvGyjzzGrVS65HzeogmU+K27pM3CSHLFOUVS2YLz8gqg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PlGmXPEaT7BRe3W0pnaZZGj4YBZ2xii8DBKqGObW74rCcbqcBvMjHUfNXs+ZbemhvBX6gZR56Hkur0l2GdRhylXd6ky0sQ3N8Tzt3tuRU3PU05ix3jTLh461bZZsUq6nM0xXfGK07VE3doteIoyuybuQVGVP+GZ1VSX88u3HM4kSAzQ4/lSWYe2XmnIkgMZIfo5Tmfs6bDi5Xt7GlrsRsNIfW2ngu/VNqoW5MR0XePgJ1vIZLYnvHFztjJWG3XkFJBnNnKKSzLCt/lATKjyiuAioVVOY0gx18wF+yKoQTKnDmLBSVtRNLZdV/UbWn4Hc6dV41tWdgTIqiq4pUSJxzA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Mon, 04 Sep 2023 13:42:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ3KWtdw8jwJKuHkKXZbII/FmnYbAKsd6A
- Thread-topic: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
Hi Jan,
> On 1 Sep 2023, at 09:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> This using a GNU extension, it may not be exposed in general, just like
Nit: Missing "is"
> is done on x86. External consumers need to make this type available up
> front (just like we expect {,u}int<N>_t to be supplied) - unlike on x86
> the type is actually needed outside of tools-only interfaces, because
> guest handle definitions use it.
>
> While there also add underscores around "aligned".
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
With the Nit fixed (can be done on commit):
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -152,8 +152,10 @@
>
> #define XEN_HYPERCALL_TAG 0XEA1
>
> -#define int64_aligned_t int64_t __attribute__((aligned(8)))
> -#define uint64_aligned_t uint64_t __attribute__((aligned(8)))
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
> +#define int64_aligned_t int64_t __attribute__((__aligned__(8)))
> +#define uint64_aligned_t uint64_t __attribute__((__aligned__(8)))
> +#endif
>
> #ifndef __ASSEMBLY__
> #define ___DEFINE_XEN_GUEST_HANDLE(name, type) \
|
