[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 4 Sep 2023 16:01:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Z6URf7VbHHuZ/hH5Ul8lpeTtPS2w+QrQSYC9K0Ba+g=; b=KiBNZqj+iZRfyizKr1zmwHmiyEO5vO3xu/vCZZIt81WafeN65t64TIydDm1GUxGlnuna14rhXGNv8IIaJKG4E0EIGTwpsxloeCwa/pW7MB8MAfQj0NxbcNU9srob+PhQkIcKL3fC7lpjeyS+EwgIR930Ll8+d3GdJjE9JpG/raJmamm94IlhbOvJLuRJt+t8DCKSZl0AM8YhmGmL8lBVNLcLigJcwmCKjdbB2Wj3eWtxMQslPKrqlc4WuaHSKnAlYquB+d8yXyluXGSd27FOB/LV/VAK6q+ppUqTWozBQ+juvYcRDWx1mQ4ob2odYqVUFWo8kbpjxALhQUCn6+fhiw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nFrsLkDkIHDXnoKAxscV846Kq/Nefs75c8VHF+3m+sC5OWGYqvsMH1C68LcM9Q9mjYabjUbphQcouuKEV5ds6QUAn3UDmcmjSRFQRUBK+9QHJtBuleoqNnAH+MZgHT+6GZkOAts3bseyE92yaIX2Mkq2EjOAoIm3EbjIcvPTeSrBiJosoWDCA9GjeRgrBwnSwlwHdwHCylcKjENvT2QynjQaSq+Gbe13s42NymYHWTxZ7KEAmUv0cwrHZB0V+h0mZQAA4VMuEwQQS5S5Y46/15kWnKmrOrxg70ZYpecXFDP979OxvVac85EvNfkiMYJVlEPC9lUC4QH90W6fxKk/KQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Mon, 04 Sep 2023 14:01:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.09.2023 15:42, Bertrand Marquis wrote:
>> On 1 Sep 2023, at 09:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> This using a GNU extension, it may not be exposed in general, just like
>
> Nit: Missing "is"
I would guess you would want it added as the 2nd word of the sentence. If
not, please clarify where you think it is missing. If so, then I'm afraid
I can't parse the sentence anymore with it added (i.e. there would need
to be further modifications, e.g. at the very least "so" after the first
comma).
>> is done on x86. External consumers need to make this type available up
>> front (just like we expect {,u}int<N>_t to be supplied) - unlike on x86
>> the type is actually needed outside of tools-only interfaces, because
>> guest handle definitions use it.
>>
>> While there also add underscores around "aligned".
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> With the Nit fixed (can be done on commit):
>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Thanks, but I'm afraid I can't take it before the above is clarified.
Jan
|
