[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 4 Sep 2023 14:05:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1KhdceH21n5rvRVhrcBVV+X1di3f8F+BTWVfSrxx2T4=; b=YmZicxleHz/2TCbD7Akb6Ci3IPEMZ1lCQyElanJPCfP2XUuIHiZYw+X7vh0dALds36lp4uDWCkcjjqsOHjlq4BaKo+oMgEz1IrWWBZNREiey2DW87+QyRbUj+gQtKTFzmZqhDces58MRsNP/fUbuZ41WeMMPxKt+gDHsBx/Ah9pqgLcStOV+Y2k2omicCJaq1ri7u3qf2/lclH3Xei1VntQSKYHn2mCTu2bnQvcg+Y3iSeq3PxHiAjzXkV/0hZjkuFk6BAs+EdVxUBJhC16vpbGR0Ph/MdE+Ui16xCAnfX/oX+75fZG8CZEyfMgEYnjngZykMWzWrMKyJM+uIZ+5yg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TP57lmiLEk+2sR5USfNuSuyz06dywob5Vk5F22IKnXCXWz/NGwt1qVKIxJvXyVOovAvHHFf9NO+H5oTvUBHl3BJU4DJnhuFSZkMMEyRDmk9kFKqKA4rkrJh2Moyw//fcGIGmVyGBBcx8bB3bkL+dlWR32u5+zIq6B6/lAJkHAtdA9LKqi6kKw8+F2P0UzNSBjfZQLdekPAoU9sxk3zgsnb5v16bSOvVvHVLsZNMjqXS3kgXDQoNUkUPOSfPA8T5+cCbMI13/qB6l5/bhM1PYONiyoeWSHwFXiDUVaQQ/sFKvNvhVhKbomx/px1y0BVUV5cEzaU4Qw5qHlJUn7C4m7w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Mon, 04 Sep 2023 14:05:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ3KWtdw8jwJKuHkKXZbII/FmnYbAKsd6AgAAFVICAAAEdAA==
- Thread-topic: [PATCH] Arm: constrain {,u}int64_aligned_t in public header
Hi Jan,
> On 4 Sep 2023, at 16:01, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 04.09.2023 15:42, Bertrand Marquis wrote:
>>> On 1 Sep 2023, at 09:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> This using a GNU extension, it may not be exposed in general, just like
>>
>> Nit: Missing "is"
>
> I would guess you would want it added as the 2nd word of the sentence. If
> not, please clarify where you think it is missing. If so, then I'm afraid
> I can't parse the sentence anymore with it added (i.e. there would need
> to be further modifications, e.g. at the very least "so" after the first
> comma).
Sorry yes, it should be "This is using a GNU".
>
>>> is done on x86. External consumers need to make this type available up
>>> front (just like we expect {,u}int<N>_t to be supplied) - unlike on x86
>>> the type is actually needed outside of tools-only interfaces, because
>>> guest handle definitions use it.
>>>
>>> While there also add underscores around "aligned".
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> With the Nit fixed (can be done on commit):
>>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Thanks, but I'm afraid I can't take it before the above is clarified.
Please see above.
Bertrand
>
> Jan
|
