[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Vikram Garhwal <vikram.garhwal@xxxxxxx>
- Date: Tue, 5 Sep 2023 11:22:33 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I7IyLr8CHuhpDduBWOMWoe1GGPPTXFXEx9y4UKXR5lw=; b=JaaMrWmHhz4fHy8RuipDz4PMbZ0j4TyAcay2YtjCawmHrvL2JVN5Wkbqe+FfCi68yuxo4/I7W7lbYybKFfyjDws9nTbjs3lldWAsJJJVCjsc+t2774d5xZL2HPsgELmkszYpmpnoJQUwVVK3d9zYQJ0+QksWxrWM9AVEN+6Qy4QX3KwYeLSum/fttUIw/Nad9av74LgZSbMVoBZYIPhEpgz36rMFwVbR3s7VvkB2BpYJqs3z1kqTwly4fBeGvbA/d2mi52SuSYt4YlclW/Oeo0Zi0D/+ilaXhf0piojoBRA5Liu2q3zn4yWxX0T25Ltpkvy5BvwL0vghxCIWIpqKQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jw0VTKN0qBaN372W/HMTYlDdSDoSGegSMIht9ctozb4ldXxdFBxZhzuYntnGZlatAHaGgS8PdLMiXwk//rRsk6jm2bQkGyIBLHldxVD1vw+X+ElQUrXg8BRucnZpUBSgzbVpYuD6KMoPW3N9Hv/4nEhJtK8b/HSmaiDp76lHnkESK/WjYggNip4Zi/7F/scAN3gJC4xJFv52yFJJrHXhqETeFjX+elEQum9uZ3KdKQxO7NRBHuNXLPLnFrkO0WoUDorVt8eps5+WUzQ2D9vcbY11AM6UGUXN/sGJaG0Y0i4o8V3+fY82LWdeVoiHFRpl54exB6iozcWK3F2kQYIXPg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, julien@xxxxxxx, sstabellini@xxxxxxxxxx, Rahul Singh <rahul.singh@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 05 Sep 2023 15:22:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
On Mon, Sep 04, 2023 at 12:38:01PM +0200, Michal Orzel wrote:
>
>
> On 01/09/2023 06:59, Vikram Garhwal wrote:
> > Add remove_device callback for removing the device entry from smmu-master
> > using
> > following steps:
> > 1. Find if SMMU master exists for the device node.
> > 2. Check if device is currently in use.
> Just like in v10: you are not checking it. I asked you to add a check
> following Julien suggestion
> but you did not reply to it. Even if you do not want to add this extra layer
> of protection, you
> should mention that you rely on a check in iommu_remove_dt_device() instead.
> You can wait for Stefano
> to give his opinion (and possibly ack this patch as is).
>
Caller checks it already so that was the reason for not adding here. IIUC,
Stefano
was okay with v10 patch so that's why i didn't make changes.
> ~Michal
|
