[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3] drivers/video: make declarations of defined functions available
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Sep 2023 14:38:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMFUiH7TPjAgom+E8xcNGRDHEluUJV3lDLbbG+jyKGw=; b=KESTLhnlahOWfIqc1A2u2BeVaA7JcvuKKMfAp79bYc/dZs2JEPidLS8D5kyTeW77LGnSno6MTtFK+9MbbXaRGQGnGVzZ3Tht4kvaBjjxwASljxHwREmDMvid38aMriF2DzwiWjba9mUovfiGVaH2+lWh3KZok8/CTReHXzUUDQKwTPD2/4xRkhp6VNLJEFAQe+/arKxI0Rn+6i6+pAYI1awszw45Lz25L/Ygr7RJA646xIx0vLixquO/c13LyHJd5LcOB0JEje18vFIxB1RTYTxRvKeOchu45PYSnhivP+4V+zees3ZAtoUPexJNbRR7/CuaP7FjWJSxc2S2ZjMVHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=af4jfIzrkJyjpexgX2B42GiKuinszw98PGMCAMaE2IrQWjxgPuaE8NazpOogkh6/tWVADNGGaGDtP+AuMBR27SHQlF7cqx4pzZVE4O7KPfcY6ySGPAV9mMYjsClfd9YFv1ihiLFnqniHsvEgZOAc6948fPozZ/Os/3/FuS/xHmipDPfA88gv7W9qtIuNCD9F7FlVOWLDWPCeKM8vgRCNFUCnhFvfDhxbKHFOC2pmUJJuNsiVuepSxRMcRoHi76blk9weUL5p+gqRpAe6Yj/ydsjGSmVhi41mDbYM3ZSSz32Qoo91VXewD7AxJ7nP9PSQ7ZfSGaxEwUzRWZq6VgqkZg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 06 Sep 2023 12:38:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.09.2023 14:36, Nicola Vetrini wrote:
> On 05/09/2023 16:42, Jan Beulich wrote:
>> On 01.09.2023 09:02, Nicola Vetrini wrote:
>>> +#else
>>> +#define vesa_early_init() ((void)0)
>>> +#define vesa_endboot(x) ((void)0)
>>> +static inline void vesa_init(void) {};
>>
>> So why two #define-s and one inline function? Just because it was that
>> way originally doesn't mean it needs to stay that way. Then again are
>> the two #define-s actually needed at all? It looks like they were added
>> to vga.c just out of precaution, covering the "VGA but no VESA" case.
>> Now that things are properly moved to headers (and keyed to CONFIG_VGA)
>> I think we'd better omit those. They can be introduced again when we
>> gain a VGA/VESA split (and a CONFIG_VESA).
>>
>
> Ok on uniforming them to inline functions.
> I don't have an opinion on the second matter. If you're otherwise okay
> with the patch
> and no one objects I can drop them.
I am okay with the rest of the patch (as always subject to spotting
something else when looking at the next version), yes.
Jan
|
