[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] xen: asm-generic support
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Sep 2023 14:40:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fd9Rl61b+F4wAgMH6fIQoygRcwqItCzl+5KoNESXVDc=; b=ZNmsrSZgkiRoqGR+YnTXaDttR5JmlqLgYNuw0AOUVlTTfC7hIgltHNb1vi2PXpOeLLS27Q55DAHKw1BzMWs5mDOtQEFX7f1QKdJK8uSFWpEAGllLqXqUpuJYJO9XBy+diS53ayA30p3TKe8mVEIHioRFBtoORQjLVCfPnBrkONjQ5dm7q8jVYo132OFV9mxYDoHQC4zBeSU2ZakTnCMO8OrAnJjCV1oUI1KHI/m+wobvMXRizQzN5Zz8K0ElMFuLTn+9LSD0AODK9RDSucSGEb7MoyLLQBPT3DEn2dvCk53paE43fNelv7KlUZRGiXBSmC51LboeSR81zXvNubaeVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JECIs4YSO0ihU1yyDnef2cTR084TXD3qpeNnAIrYocQe5Ea9YZupuLX4p9ck3yQgL7N52rCyITHzUlcJJ3UjlRJQYmQAT/agPMDquIQqFiAk7iRF3T31j8wrJitBfocSTcJJvRe5JXHrpoX5csaCdf9iNueCzcBvxLcrEfeZA70cJLipVEmP+P/nAmjsmTVInBo28oFwAF/D67e5P1ce0H2MCFrgzAWE91BgW9qByEW2d3bhvNK/yty28ywx5S/wM5FNbIZGhFm9WQkoluMdEDhewsTMphCLbiOuS9K46d5xhVhIt1HofQ37y10PNrI6UnEP65jp6pZkJLPMQvnVGw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 06 Sep 2023 12:40:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.09.2023 14:28, Oleksii wrote:
> On Wed, 2023-09-06 at 14:16 +0200, Jan Beulich wrote:
>> On 01.09.2023 18:02, Oleksii Kurochko wrote:
>>> --- /dev/null
>>> +++ b/xen/scripts/Makefile.asm-generic
>>> @@ -0,0 +1,23 @@
>>> +# SPDX-License-Identifier: GPL-2.0
>>
>> While this is what the Linux file presently says, you still want to
>> add
>> "-only", which is merely the newer name for the same thing.
>>
>>> +# include/asm-generic contains a lot of files that are used
>>> +# verbatim by several architectures.
>>> +#
>>> +# This Makefile reads the file arch/$(SRCARCH)/include/asm/Kbuild
>>> +# and for each file listed in this file with generic-y creates
>>> +# a small wrapper file in $(obj)
>>> (arch/$(SRCARCH)/include/generated/asm)
>>> +
>>> +kbuild-file := $(srctree)/arch/$(SRCARCH)/include/asm/Kbuild
>>> +include $(kbuild-file)
>>> +
>>> +include scripts/Kbuild.include
>>> +
>>> +# Create output directory if not already present
>>> +_dummy := $(shell [ -d $(obj) ] || mkdir -p $(obj))
>>> +
>>> +quiet_cmd_wrap = WRAP $@
>>> +cmd_wrap = echo "\#include <asm-generic/$*.h>" >$@
>>> +
>>> +all: $(patsubst %, $(obj)/%, $(generic-y))
>>> +
>>> +$(obj)/%.h:
>>> + $(call cmd,wrap)
>>
>> You've removed quite a bit of functionality, comparing with the Linux
>> original. May I ask why that is? What they have all makes sense to
>> me,
>> and looks to be useful down the road.
> I decided to take only minimum needed now but if you think it would be
> better to use the latest Linux's Makefile.asm-generic then I will
> update it in the next patch version.
Unless there are things getting in the way, I indeed think it would be
better to take the whole thing largely verbatim (a few edits are
unavoidable afaict).
Jan
|
