[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 1/2] xen: asm-generic support


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 7 Sep 2023 12:48:25 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j26Dccb4Gznq2tdMBzA/AAZgU2iq5DM14sZoKN40VOc=; b=mjUyx2T0rVLH09vPtpPQPuu2M6i9PrfTWznCDYCD6MFs9oPyyU1O6Vkk6g/oHoA3OcqtaDMRa29xan4tNOU4IlQ9gjc7x0a1IxjdFBAvaQFTl/9zpWR32xJ/Wp2Y/vK1JtDO3dHD11tluFISN3CRY9WhwsCX6ztjtEZR8XSYdvMdoHitNxXh+8qqasfxBqwn2NsAVOZhdw+AcURyszY5055ktckjyglHioG3s6bY5MhvMwZkqiUCLM09tl5ZMKM7vut8VG5J+pKvZxIwtqWvjtK9oPXwi+M+zE514DKtPR2BJgj5lgSDCAC9TTgLcUrChUxGD33LwQ6g8JG/dWwBHg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LPIAmrQkZ88QCJS6EmUdJoLWxBvKKpMVoQ9Zf0tIsCUmj8pAEBQgSZw4RKk6okY1UEC0s2B+NUnQpeCxznLWynbbtbWKdAz/55CU8qwr6ES9IWeZZILkUDvb4DPZiSeEL3j9kyl3McGzBBcXvklVVs8FoCDuUOQdSGaECJGgD0izDnS0nSpGQy4DwPZgw89RptBS61BHEcdnnH4luqA6UF5RLyIEXrKEpP2mKbmr3FiJqv9ekgja6jg+MDTKrnLRdwF9yXYsVmf66PdKyHOb+V3+JPT7z01XK67934X4wnC94/BdEltLix4WiE0wFFbo9X15r2HfcB0FH3xp5w3u/A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 07 Sep 2023 10:48:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.09.2023 11:32, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/scripts/Makefile.asm-generic
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +# include/asm-generic contains a lot of files that are used
> +# verbatim by several architectures.
> +#
> +# This Makefile reads the file arch/$(SRCARCH)/include/asm/Makefile
> +# and for each file listed in this file with generic-y creates
> +# a small wrapper file in arch/$(SRCARCH)/include/generated/asm.
> +
> +PHONY := all
> +all:
> +
> +src := $(subst /generated,,$(obj))
> +
> +include $(srctree)/scripts/Kbuild.include
> +-include $(src)/Makefile

With the definition of src above, is this correct for out-of-tree builds?
You want to reference the Makefile in the source tree, ...

> +redundant := $(filter $(mandatory-y) $(generated-y), $(generic-y))
> +redundant += $(foreach f, $(generic-y), $(if $(wildcard 
> $(srctree)/$(src)/$(f)),$(f)))

... much like $(srctree) is used here (and similarly again further down).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.