Re: [PATCH v6 1/2] xen: asm-generic support

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Thu, 2023-09-07 at 11:08 +0100, Anthony PERARD wrote:
> On Thu, Sep 07, 2023 at 12:32:56PM +0300, Oleksii Kurochko wrote:
> > diff --git a/xen/scripts/Makefile.asm-generic
> > b/xen/scripts/Makefile.asm-generic
> > new file mode 100644
> > index 0000000000..92a3a741c5
> > --- /dev/null
> > +++ b/xen/scripts/Makefile.asm-generic
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +# include/asm-generic contains a lot of files that are used
> > +# verbatim by several architectures.
> > +#
> > +# This Makefile reads the file
> > arch/$(SRCARCH)/include/asm/Makefile
> > +# and for each file listed in this file with generic-y creates
> > +# a small wrapper file in arch/$(SRCARCH)/include/generated/asm.
> > +
> > +PHONY := all
> > +all:
> > +
> > +src := $(subst /generated,,$(obj))
> > +
> > +include $(srctree)/scripts/Kbuild.include
> > +-include $(src)/Makefile
> > +
> > +redundant := $(filter $(mandatory-y) $(generated-y), $(generic-y))
> > +redundant += $(foreach f, $(generic-y), $(if $(wildcard
> > $(srctree)/$(src)/$(f)),$(f)))
> > +redundant := $(sort $(redundant))
> > +$(if $(redundant),\
> > +       $(warning redundant generic-y found in $(src)/Kbuild:
> > $(redundant)))
> 
> This warning would need to say "$(src)/Makefile" now instead of
> Kbuild.
Thanks. Missed that.

> 
> Beside this, patch looks fine to me:
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Thanks,
> 

~ Oleksii