[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"


  • To: Borislav Petkov <bp@xxxxxxxxx>, Elliott Mitchell <ehem+xen@xxxxxxx>
  • From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
  • Date: Wed, 13 Sep 2023 10:36:50 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahnKZmxJT8dusQtBeSkWr2k8rK751AY00jAIFynw+14=; b=ctReq4SL0yyXQYXcoE79uIEVlehvamEeiZt2Aa83B5ok2aQVMJveLbxC1DDBXjdgajBua+gOs1TIvCHUx3C7nR0ywVdEeZuyg/Vbxi61rKRZpZaVtaM3RiuKy6jeaUOS8dE2CoW/mtxLcozTqiVtRvcrWOqI0UDcdGcrVPY4GGvPSZrTZEBK4XuRzbzCtcvQNrqIQ03GMzoyYpl8y7kndPPugF6Bgq4u49nqrb3kMnifeHpSQuvj3Ax4X0umNPjMkzgPOAtr5Iw6FpM8Swcv+yXSjq2IlU4HLcOzY8c0dI6rM/01Owo3/Bt1Ba3oNJpWRaKig0sFpWW8ZQfdTYYkLw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hUNQ10EhbuDA8TPz6UTYxxdItFd9EvVpbt9+x1bKFuYrxguy9Z0Bb5vJ2i/tm5J3G/IDy6Raee4DUOZKb/CanCRKjx5oa7zxCaKsFg8mXQ/2RJuMmt3cRxB5oqLZuSTmq5n9ZKHNqeMVRslzzw0WPUiKMbU4TyPflYoha0y1Bnk9mtzUNKcf665PLsl/eKeJ4aG2G+R3tNhlqip53XSAIveLfh/cKO2EkAkNR4jO8h/nDR3dkqUpVtdFFLPztgZfq8VPJdFuPcOyceeZXJMc3Ar3TBEKFiMaj4E4XT/KN0preSx28ToUahgsSiCOzDvIZuRk+iO+OLMtJhestXiRhw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: yazen.ghannam@xxxxxxx, smita.koralahallichannabasappa@xxxxxxx, linux-edac@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, rric@xxxxxxxxxx, james.morse@xxxxxxx, tony.luck@xxxxxxxxx
  • Delivery-date: Thu, 14 Sep 2023 04:45:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/7/23 11:59 PM, Borislav Petkov wrote:
> On Thu, Sep 07, 2023 at 08:08:00PM -0700, Elliott Mitchell wrote:
>> This reverts commit 767f4b620edadac579c9b8b6660761d4285fa6f9.
>>
>> There are at least 3 valid reasons why a VM may see MCE events/registers.
> 
> Hmm, so they all read like a bunch of handwaving to me, with those
> probable hypothetical "may" formulations.
> 
> How about we cut to the chase and you explain what exactly is the
> concrete issue you're encountering and trying to solve?

Also, please note that the EDAC modules don't handle MCE events
directly. They act on information passed from the MCE subsystem.

Furthermore, there are other EDAC modules that have the same !hypervisor
check, so why change only this one?

Thanks,
Yazen



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.