[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"


  • To: Yazen Ghannam <yazen.ghannam@xxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Elliott Mitchell <ehem+xen@xxxxxxx>
  • From: "Luck, Tony" <tony.luck@xxxxxxxxx>
  • Date: Wed, 13 Sep 2023 15:50:12 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/GThrrS38ODFaqgFkp5l+ooqfkqDQHpUWh5u/78uYs=; b=BiDsZ9zGOrxvGnPBfTZPdZrsvNQMYASk95vL8o+ZY8M4Nj0P3uGl5qBy9a6tbF5GmGG62MmuQOohJH2Ye+R3PQtF54mnYy1AVEqUMhlQGbfmqnvM7JXu67qPjwOv15joeeoFfEJ/NUUuIKx4Y3AC4k70U2ma/REXzUM5t2HteHEvmz/9he1itvczceeYW9+DJDjoaO5K3VuBv4zMGwXsleX7kTIG1ilt3DCcjlc8YAjuLx0ocys14fICMQiAay4k+tV0fB6WUiCaVky+RmvZCXmPWaDqCMvcDuLA1PYTqbXG+QsXdYJVXptnjJBv7hy42ZYliBIdEwVDMNUgKefGaA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FErUEGCsMxgq6/pegpE4q6K76mN+tAer5cdKQhYEwdSEERa+K/E5wAABUna/x+Vr6ukzim2nJ/qQKlqkod/vdkJB8K42X4G1ZBU4jc/CRIJj2cBytp2y3MJmdRMvGe5vxcsJTMw/0PRUzMURBw/b4yqp401J1fY2qZ6MBgoCVOKj5NsUh/woAu4+fbvQUdOn+L+4S0zhtvL3ka8Lglwek527tMdj5yAKAkVgLOKUH06OCs4pWsZbRK4cMeg0sUnR16d0mPc9Q9TCLA9RKbL69GMExVBn6wjSRJQw8NTQX31ijNzRgRPQOcasFvuLSgDWPWKWAXLxucVGP7JQNCj/lQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
  • Cc: "smita.koralahallichannabasappa@xxxxxxx" <smita.koralahallichannabasappa@xxxxxxx>, "linux-edac@xxxxxxxxxxxxxxx" <linux-edac@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "rric@xxxxxxxxxx" <rric@xxxxxxxxxx>, "james.morse@xxxxxxx" <james.morse@xxxxxxx>
  • Delivery-date: Wed, 13 Sep 2023 15:51:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHZ4gHSSeZV30FbCEm60ywcBMZ8pbAQTaKAgAiN0ACAABNOsA==
  • Thread-topic: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"

> Also, please note that the EDAC modules don't handle MCE events
> directly. They act on information passed from the MCE subsystem.
>
> Furthermore, there are other EDAC modules that have the same !hypervisor
> check, so why change only this one?

The older Intel EDAC drivers translated system physical addresses to DIMM
addresses by digging around in the CONFIG and MMIO space of the memory
controller devices. It would seem unwise for a VMM to give access to those
addresses to a guest (in general ... perhaps OK for a Xen style "DOM0" guest 
that is
handling many tasks for the VMM?).

What system resources do AMD EDAC drivers need access to? Could they
work inside a guest?

-Tony



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.