Re: [PATCH v2] xen/arm: Skip Xen specific nodes/properties from hwdom /chosen node

[Julien Grall <julien@xxxxxxx>]

Hi Henry,

On 13/09/2023 01:49, Henry Wang wrote:
> Hi Stefano,
>
> > On Sep 13, 2023, at 01:46, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> >
> > On Tue, 12 Sep 2023, Michal Orzel wrote:
> > > Skip the following Xen specific host device tree nodes/properties
> > > from being included into hardware domain /chosen node:
> > > - xen,static-heap: this property informs Xen about memory regions
> > >    reserved exclusively as static heap,
> > > - xen,domain-shared-memory-v1: node with this compatible informs Xen
> > >    about static shared memory region for a domain. Xen exposes a different
> > >    node (under /reserved-memory with compatible "xen,shared-memory-v1") to
> > >    let domain know about the shared region,
> > > - xen,evtchn-v1: node with this compatible informs Xen about static
> > >    event channel configuration for a domain. Xen does not expose
> > >    information about static event channels to domUs and dom0 case was
> > >    overlooked (by default nodes from host dt are copied to dom0 fdt unless
> > >    explicitly marked to be skipped), since the author's idea was not to
> > >    expose it (refer docs/misc/arm/device-tree/booting.txt, "Static Event
> > >    Channel"). Even if we wanted to expose the static event channel
> > >    information, the current node is in the wrong format (i.e. contains
> > >    phandle to domU node not visible by dom0). Lastly, this feature is
> > >    marked as tech-preview and there is no Linux dt binding in place.
> > >
> > > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >
> > Do we need Henry's explicit approval on bug fixes at this point?
> I think it is a bit too early, we can wait for the code freeze for the 
> release-ack.
> Before code freeze, maintainers/committers can push the patch as usual.
>
> Anyway, I agree this patch is definitely qualified to be included in 4.18 so 
> feel
> free to add below tag if you want.
>
> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Thanks. It is now committed.

Cheers,

--
Julien Grall