[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 00/29] Introduce stub headers necessary for full Xen build
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Sep 2023 11:29:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0BvkfHbyYBZ2ENgsnsxNoJOZF0YHMbHuBBEbvoaXwfQ=; b=XUshWUbEXAyrLNMWLQ6i1rGiug7XWvXMLbU7Hy8sGeSsX3DG97JIQxI2SyjWWFotXXk0IIA0qJ/G6DRVWMiFo90mjPiqVTLZlFe3CWU3zbAsjUlgO5EkEs/GnHClamp0tiYpXSVsvuOr9GOrvFYevaLAA+5/lbxInWa2TAPCjy0I0bhR49PEox3y7UkDA4rH5ZFdTK8IF8A4NiA6iRoH75NNITfTsH5wyqAOO8HJvSlTgtgRsGX1QzMINAHxP7BKFWOQhWMEFLs3e5CSJfiWxCR7uXuIPZVZqCceFy9j4d7tK/PEhTtv5af2gVa1k0mwPIWcvdxjcB3OssXZUHGpAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0AESs3sfp2Lx8vbqjGmxc6uzUQUQjvK52XeyW4iuI4ktcAfTGBA4asYxkCCkZhSvJDCloJMPYJuQmhZw9h4pdCv/6SyhJbJRzDcfoW6NZ7dJT4GHG0txYGx2cLsBpWc6eKUSGVBnX/PSu8P5ex/ZFE6pgYUFp4TkuFOSssyl2DVSoSmcqnZIqqmpNwQw0hvDuwn9XxACv8wVnjLM8TpTd0nbK8Na1BjLFhF6PMi3GDNLoCK8Zixjkx3JCAVMQIWksob6JzyiNgCAB9aGTBwI3nk++fVL0Dw9qOeAHCIAytJeTpzxQDi6BIF+qtqKUA8DHZ7I/rnT+RTAHbkiQmaxA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 18 Sep 2023 09:30:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.09.2023 10:51, Oleksii wrote:
> On Thu, 2023-09-14 at 17:08 +0200, Jan Beulich wrote:
>> On 14.09.2023 16:56, Oleksii Kurochko wrote:
>>> Based on two patch series [1] and [2], the idea of which is to
>>> provide minimal
>>> amount of things for a complete Xen build, a large amount of
>>> headers are the same
>>> or almost the same, so it makes sense to move them to asm-generic.
>>>
>>> Also, providing such stub headers should help future architectures
>>> to add
>>> a full Xen build.
>>>
>>> [1]
>>> https://lore.kernel.org/xen-devel/cover.1694543103.git.sanastasio@xxxxxxxxxxxxxxxxxxxxx/
>>> [2]
>>> https://lore.kernel.org/xen-devel/cover.1692181079.git.oleksii.kurochko@xxxxxxxxx/
>>>
>>> Oleksii Kurochko (29):
>>> xen/asm-generic: introduce stub header spinlock.h
>>
>> At the example of this, personally I think this goes too far. Headers
>> in
>> asm-generic should be for the case where an arch elects to not
>> implement
>> certain functionality. Clearly spinlocks are required uniformly.
> It makes sense. Then I will back to the option [2] where I introduced
> all this headers as part of RISC-V architecture.
You did see though that in a reply to my own mail I said I take back the
comment, at least as far as this header (and perhaps several others) are
concerned.
Jan
|
