[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen/types: address Rule 10.1 for macro BITS_TO_LONGS
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Sep 2023 11:59:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7vkPfv6tHqwQP+MdMC7c82HnAW22ZJ7qxNfGeLESBNU=; b=cX0056dh/yaOG4HKsNQh9ISoN08hh5spUq6FRlGAmFMmkDgwlZoGRSPGWJw3YmFn/bt4lvySXkOKajnejuzmmQspKyR8rXRNmr0Oc1Y/c8bKvF9BjTAOAEe7K2uLpQbjGvwfVz764H2xGQfO0I84rGRvxkBmOKuZt58SZM2JW2T+NwNDseLzhd8UA36nMkIubViCEmXxSlWWSG6fuH1KUDdFEAR/r12Aenax0BnoebK81FD2wQTxXLLL6UpiTh2ADSOdciC0MgrobogQzFJxo4LXKICtX9EHauxyFhS5PfiDvx2lpKGwsqP0rHYRVcCXFq9dfMehztvSkK30imXPPA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k0PRb5luLvuQHbvpS72RulqydZJWftmySC5GeythAssdaoQcBX4mX9gynzUN6KFUFwSe5v6I0T2vwrXs0bP9cWCAfVCoknVnOgDwys0TXL0Yf3ULbaY5Eoz0gO+9FaiuJ6x7QM5HnT9oKLRQnmweX9q76ZlW/Nc1IT8sbXM9Z1FKoO1xp3K6L4oVrnPO5wg3DpSNKj65flvODpRYVoav5H2XpiHVVmjLAuYh0d5t31nnme0gDOHJTXnBYNjX9aoL2xpoGQQYOi0sAYiMKM1kcPMxInIFfeQ0tZ0x2rTn/FzjsaBANt0tTkOaRC2hq5YH47ThLOLW12Lsf7EfIOjnLQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 19 Sep 2023 09:59:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.09.2023 11:54, Nicola Vetrini wrote:
> On 19/09/2023 11:33, Jan Beulich wrote:
>> On 19.09.2023 11:19, Nicola Vetrini wrote:
>>> I just noticed one further issue with making BYTES_PER_LONG unsigned,
>>> in
>>> that causes
>>> several instances of (1U << 3) to appear inside the file
>>> xen/arch/x86/xen.lds
>>> produced by the build, which in turn causes ld to fail on that 'U'.
>>
>> That should be avoidable if _AC() is used in the #define.
>>
>
> I think all instances on x86 are caused by
> . = ALIGN(POINTER_ALIGN);
> where, for all arches in xen/arch/<arch>/include/asm/config.h there is
> #define POINTER_ALIGN BYTES_PER_LONG
>
> $ grep -B 1 -A 1 "1U" xen.lds
> *(.data.rel.ro.*)
> . = ALIGN((1U << 3)); __start_vpci_array = .;
> *(SORT(.data.vpci.*)) __end_vpci_array = .;
> } :text
> --
> *(.init.bss.stack_aligned)
> . = ALIGN((1U << 3));
> __initdata_cf_clobber_start = .;
> --
> *(.init.rodata.*)
> . = ALIGN((1U << 3));
> __setup_start = .;
> --
> *(.bss .bss.*)
> . = ALIGN((1U << 3));
> __bss_end = .;
>
>
> Do you think changing the definition of POINTER_ALIGN will break
> something?
Why (and in which way) would you mean to change POINTER_ALIGN?
Jan
|
