[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1 1/3] ARM: GICv3 ITS: issue INVALL command after mapping host events


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Tue, 19 Sep 2023 11:28:53 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EL8EW1Wf0smeCmefyJe62z5xVjR7Rx7TyTl1SpuYNzk=; b=ns6hNNcTve8T1hnjLJ9pj4DN51MJ+SIxFmPGpthCMcVmDyb+tOscmQdMyRsnat3v8Q9gFLgDCLULy5LiaQpRHm10lxSRGEFSemPCRmm4eJ+fGt//jtsOA9STRBO8HtBow4hsQKbIcn8j7fgoYvrbNQwaX+Q6AYwWwyvAhl7+WzeKlPGAIC9wSLN7JX/ES0NGPQX3Hi30DEgLocshZv0G3TqN2vnR6Cs/8lksBIfLJAeFrvU9uGa/A0T7n8yfV5+ydKxA8aWL7yz5RkYhFHwrYbfb2Yw8ULDeHW8+urCWv+UlmPtd7REoeO1NHpU485ho3RH9lQ0tPr2vJKctojjR4w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrN+YelRVlyAqafvyMDD5UVT1308p/9vQPTTFLIGB6mveq4rumu/KGngfK13mJh8yOMeptsjMhqoCOtePlLEISy3c/MyPNSX1jH2LlvTQ5gfHDjQDtNNEVXbiTR8jy4C9eJ1uCxZ+vSLW7eJTEjB82+My6WutQ8k6ZPIhzx159BhZxFu27Y5EKmkemnbFhs+JZ9rEzUwtxZlOB2yDRLtJplVwDwB0hydmU8pWtrSVav5B7ZEgJWR5YwODjqP6yAcgirffwqC7J9joSMhfxyHZA7/Tj2o8ttz8n1QvqvKPAAZcRZ6MbOjS1QytWUby8SZ8ABJ0kj13iVcuN/LCxxh2Q==
  • Cc: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 19 Sep 2023 11:29:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHZ6ux4J+vpvrMLBESLD/bhCu4NsQ==
  • Thread-topic: [PATCH v1 1/3] ARM: GICv3 ITS: issue INVALL command after mapping host events

Implement TODO by calling the INVALL command. It is working on real
HW, so there is no sense in not doing this.

Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
---
 xen/arch/arm/gic-v3-its.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index 3aa4edda10..a9c971a55f 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -236,6 +236,19 @@ static int its_send_cmd_inv(struct host_its *its,
     return its_send_command(its, cmd);
 }
 
+static int its_send_cmd_invall(struct host_its *its,
+                               uint32_t collection_id)
+{
+    uint64_t cmd[4];
+
+    cmd[0] = GITS_CMD_INVALL;
+    cmd[1] = 0x00;
+    cmd[2] = collection_id;
+    cmd[3] = 0x00;
+
+    return its_send_command(its, cmd);
+}
+
 /* Set up the (1:1) collection mapping for the given host CPU. */
 int gicv3_its_setup_collection(unsigned int cpu)
 {
@@ -593,7 +606,9 @@ static int gicv3_its_map_host_events(struct host_its *its,
             return ret;
     }
 
-    /* TODO: Consider using INVALL here. Didn't work on the model, though. */
+    ret = its_send_cmd_invall(its, 0);
+    if ( ret )
+        return ret;
 
     ret = its_send_cmd_sync(its, 0);
     if ( ret )
-- 
2.42.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.