[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement
Hi Henry, On 16/09/2023 05:06, Henry Wang wrote: Some addressed comments on enable_boot_cpu_mm() were reintroduced back during the code movement from arm64/head.S to arm64/mmu/head.S. We should drop the unreachable code, move the 'mov lr, x5' closer to 'b remove_identity_mapping' so it is clearer that it will return, and update the in-code comment accordingly. Fixes: 6734327d76be ("xen/arm64: Split and move MMU-specific head.S to mmu/head.S") Reported-by: Julien Grall <jgrall@xxxxxxxxxx> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>I plan to commit this patch in staging so it is part of 4.18. Please let me know if there are any objection. Cheers, -- Julien Grall
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |