[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 22 Sep 2023 01:14:58 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vxYVz3prC4xV/U9J5EJnRp+tM5e6ax3pGj6ME4iASRk=; b=DkOt4kre7igeP83ihbgwoFEQb/dha+jXPextkDKFmxRQy1sdKvjjORLA2uB9SlOiywBbHaALlbHLnoSNioaqJrRN8AvEnXZixAnz55J80L3iWjhYlImlOEdCOuf+f+agPiqKcn0yiG7rh0AUU8hvDWvCiU+qzCjKBkF3tyriFduGR6Xs4LLtgGzy/twDPM7+n0AQAmpoqQIThmSf+uXa0HSKs2Ty2Ew7p7UbDPRDCS2qN4L85/D2PbBBZ42wwKoxfGZ2cSpj+6B2JwnMCXu56jTOPZXnzC+mf9ioAatz+tq4OPzT56lDOeMYnSVPUPD7D2fdiN0uU0AtlU5gtdRAug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XmRKzjyiuum8K3YQieWK+4MvPBWP1+ao9Z49nZbbyX8MP5HxPdftVVpEyJDN1ocbkz0dRmFgBClBNB+n+8+Va8umvXf2ljCN6V6obA/D9C+akvsVL4pbeYaJtzt4Ti8j/KGSWvHukGxvWHsY2gvy70BwVg1Vmpl9Ws9ZgxTes6atsLvSRHx8Y7hzBRJkVWWoKR8WN6c5/tFlATZKdyz+JoqRfQThGirr9r+VaFm9QY5jMSCZTiOQ5O8pEm592DQjEfS21ZBM7MSQf291aKTOJ4GR3mbFJ+iX18twPVt2gLa0iMsWxuPvL9IG/VzGfuFITQMljaIc8lFfa8E+0zcdBQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Fri, 22 Sep 2023 01:15:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ6FNGXuwkZcMSWUGVwj7cDe3WUbAljiuAgACFiYA=
- Thread-topic: [PATCH] xen/arm64: head.S: Fix wrong enable_boot_cpu_mm() code movement
Hi Julien,
> On Sep 22, 2023, at 01:16, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 16/09/2023 05:06, Henry Wang wrote:
>> Some addressed comments on enable_boot_cpu_mm() were reintroduced
>> back during the code movement from arm64/head.S to arm64/mmu/head.S.
>> We should drop the unreachable code, move the 'mov lr, x5' closer to
>> 'b remove_identity_mapping' so it is clearer that it will return,
>> and update the in-code comment accordingly.
>> Fixes: 6734327d76be ("xen/arm64: Split and move MMU-specific head.S to
>> mmu/head.S")
>> Reported-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks very much!
>
> I plan to commit this patch in staging so it is part of 4.18. Please let me
> know if there are any objection.
Yes, please commit this patch, as it should have been part of the committed
patch
6734327d76be (again I am sorry for the mess).
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
