[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v4] drivers/video: make declarations of defined functions available
- To: "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 25 Sep 2023 11:11:26 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JgfUXEUsclrNv2W7ehQdHKt6Eu82+bdctyihwVew8YI=; b=YmXIhZjG3nqY5I8VoCaBCQlg5NZD8vA3dn8LoaGfCo7s/4yqlBwFshuNNjsvyl2TPblBtA2dMvJMHJQaQnxcjo7ytSe7c+aPg1EiBM5HCYRlppSuSpsHHJahF4NW0iai72jO8ja+5QcLH0WUfT7ESilOhUjYS3+nWmTOL9gb/7jYrEgjcYSgLarNCytEJEfC+CBws6FzayBtsV9QUoYUNRQdHvg62TGxsivLUUYFl36TBaX2mEQOxOo6V1HMqcctylnu1i7wRr9vpgXz+idYhHScBLj8s9vxL8V7T6CsuboW4jhdUX2GnMpoqZzLA8XGG3JUm0KnCf/t99EZS6O7iQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fp/e7zinK0e3uNKG8QT0+oEJWjmsKoFHy5zPR6MhzVchQjnn95tBSXLMRFxoK4EmT4RFjAoY72uN6EnMw+vwm2ZgfRrRIk03aFnvrxDN91QGFBKoFESZb+f9/LZANtbGRHPJl3EqP+KOmvsxi7HxOp6s8xr9CfZtFODZCUG2Wr21awf6oFVKMby9bJ0r6sOMMpejvPKgV1ET9wMExvSKCKfGXlA0F+QgiewDhw/8O3ANz8faLkJeH49N4JKelwTa6RPI2HXZuPPmWr+HtWbfmlosFiYdvNN07tJkxRbpziloqfEdXULKa+19KUdTCCia/VYiTSISsdtfiDehUoPorA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Mon, 25 Sep 2023 11:11:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ75BxeEriYuxeZk+v70ty8+HkJrArXccAgAAFGAA=
- Thread-topic: [XEN PATCH v4] drivers/video: make declarations of defined functions available
Hi Andrew,
> On Sep 25, 2023, at 18:53, andrew.cooper3@xxxxxxxxxx wrote:
>
> On 25/09/2023 10:11 am, Nicola Vetrini wrote:
>> diff --git a/xen/include/xen/vga.h b/xen/include/xen/vga.h
>> index f72b63d446b1..9b2c47971d0c 100644
>> --- a/xen/include/xen/vga.h
>> +++ b/xen/include/xen/vga.h
>> @@ -13,6 +13,12 @@
>>
>> #ifdef CONFIG_VGA
>> extern struct xen_vga_console_info vga_console_info;
>> +int fill_console_start_info(struct dom0_vga_console_info *);
>
> ci
>
>> +void vesa_init(void);
>> +void vesa_early_init(void);
>> +void vesa_endboot(bool keep);
>> +#else
>> +static inline void vesa_init(void) {};
>
> Extraneous ;
>
> Both can be fixed on commit, but we're in code freeze now, so every
> patch needs approving by the release manager (Henry, CC'd)
That is very nice of you, yes please kindly fix on commit, feel free to
take my tag:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> ~Andrew
|
