[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v4] drivers/video: make declarations of defined functions available


  • To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 26 Sep 2023 09:57:22 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3AkAkYna7Kmz9Ysq8cHo6Tdv+BmzUMpUCx8jq7TBk2A=; b=iJAFuRevbcPw7KHIstKmSqnpWKWJ2xocq9wX/KunO16jYZ2odvQ4gb1ut6y95DS2RleLefWr8lMtjXlY74gbOHtuLWKSw3mJGvcdZmHffoSNbskDSVze5EQoMcq+SPeTTgR9+PpAZC/w1Udh28vF75h8F/jm7RkY2ce7r7O8v8Ke0MdD8BDxfiODNHCdIBnNQ3sDrqOC9+P5FO+1w7yCyGFf+fmad9A6X0GcCW+MuswT9NW1vNwjJXGjsG4QVGbvJ7ymrNWb9cwN5sSzJNvIfbB9hSalKFdHN7psduwzWRpbCkwLptT8v0eXBZxh+cn4xiLJQWLfbABHjPEcGcwAaw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJf5XJ4us/okNJOuoaTotuIG9Jh3EB5cMMCQ1va+aepsZHb+QZV+NOJ4ZbJQ0osMxqT7524F8DJHnlAIOua4gD3PuMSDsJBq+/p5++X9QZSpJ+yB6lqt8vcRL8f1OQQpvxfn/ixWgpC54J7W3QbzGqyaS0XtBaIFX56wyDBWVBG78pwJSvUhpE6No/gv9qQe9JHW4sEI+ZTbTfJRd6yBEI3dIcweKVD/4WXmm/zvoG7hFgkouwwhTuQItlaCtEfMtLhVQ1k97aukaFdlJfd+ZZrtUgxXADpHvKIINAwXZcBcJaqgtZuxhKHt6bIjWa/9KotgyMN7ktNzJ+aI9E7SfA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx
  • Delivery-date: Tue, 26 Sep 2023 07:57:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.09.2023 12:53, andrew.cooper3@xxxxxxxxxx wrote:
> On 25/09/2023 10:11 am, Nicola Vetrini wrote:
>> diff --git a/xen/include/xen/vga.h b/xen/include/xen/vga.h
>> index f72b63d446b1..9b2c47971d0c 100644
>> --- a/xen/include/xen/vga.h
>> +++ b/xen/include/xen/vga.h
>> @@ -13,6 +13,12 @@
>>  
>>  #ifdef CONFIG_VGA
>>  extern struct xen_vga_console_info vga_console_info;
>> +int fill_console_start_info(struct dom0_vga_console_info *);
> 
> ci
> 
>> +void vesa_init(void);
>> +void vesa_early_init(void);
>> +void vesa_endboot(bool keep);
>> +#else
>> +static inline void vesa_init(void) {};
> 
> Extraneous ;

And with these adjustments
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> Both can be fixed on commit, but we're in code freeze now, so every
> patch needs approving by the release manager (Henry, CC'd)
> 
> ~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.