[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/10] mem_sharing/fork: do not attempt to populate vcpu_info page
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 5 Oct 2023 14:42:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FbvOFJRJCPcQf1LkXr1V45MH41cBLOLTPVyq5i9ZUac=; b=JHyVJyUCg6pUmVTADD2y2nveCszEP9hm0qRjrP3w8Rp2XDqxtiNVVkllH5NQeja08CsX0mz11ztOh/XLR7g7j0nuAVHIiy++K1i8ilWzMkrt9W4rYIguWTUz2vM5SUFnCK4P/szGTQHU4271ZEYnidBTUkrW9G0l7holOGDuQHLHiLs0Kev0c5SNeGC47TIPtVcvMlDMl1pTGGivPDHt13u3n9+1vNnP8iWC5oeuJsmDIvKWE1b52ts9EDq6thud69psyOBY8fDCE6rfGsKgC7/raWxHDvAfI8ln5uwWasm/vud/ewS4EAiUbKPbw7rCYjvwgPQyLxFK8QxxEr+mtg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7FmqnjDlyt9BvAlEKxyw7nsa91xgoDLkwPmybxJXfUlfrvyR8KbK6+Iu1GeefGMiyBd92KJaUL9tmbij6FRay6zIUPgDY4hNUE6BZtfWWNd4fZx/1iYtmPVnaPtMlJ7vbB+xLRFF1q6tVEPXOS990yoHBQJ/YbIuVrNjLRpQNu2OHKf98ADx8b/O/QFTIZeDGJmCrtarCX9m/7ukXt002fsOF/MaU4nfodXbyabSFRJBG20vdkdK0hkzvBBFcylEUTKxVB05TOJnriNphlE49HO6Vigne0VKAqBkFf3VucAHzJZDE1oniYOI3IKBQyW/ZRWrPzUn8HaZvzkWzA7ZQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, henry.wang@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Thu, 05 Oct 2023 12:42:24 +0000
- Ironport-data: A9a23:s5pbJalCJHRP+OwKLk/Sfyjo5gxYJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJDTrSb6uIN2Dxcop0O4jl9ExX7JWHxtZhGwI4/ChmQyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+e6UKicfHkpGWeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K+aVA8w5ARkPqkT5AKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dc7NzUXak/Yvr2z8OuWaPVDm4MhdOC+aevzulk4pd3YJdAPZMmaBo7tvJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3iee1WDbWUoXiqcF9hEGXq 3iA523kKhobKMae2XyO9XfEaurnxHmnBd1DSezhnhJsqAyT2EoVOAYubleyotK/jnPuddhWB nVBr0LCqoB3riRHVOLVQxS9qWWsoh0YVtxfAuA+rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqd+7GOvHWtMC4aBWYYYGkPSg5ty9vprZw3jxnPZs1+C6PzhdrwcRnvx xiaoS54gK8c5eYJyqG68Fbvkz+q4J/TQWYICh7/W2uk6kZyY9ejbonxsFzDt68fdMCeU0WLu 2UCl46G9ucSAJqRlSuLBuIQALWu4PXDOzrZ6bJyI6QcG/2W0ybLVehtDPtWfS+F7u5slefVX XLu
- Ironport-hdrordr: A9a23:X+wjOKvxX1ztc9vDdTymFqD07skDgNV00zEX/kB9WHVpm6yj+v xGUs566faUskd2ZJhEo7q90ca7Lk80maQa3WBVB8bBYOCEghrOEGgB1/qA/9SIIUSXmtK1l5 0QFpSWYOeaMbEQt7ef3ODXKbcdKNnsytHWuQ/dpU0dMz2DvctbnnZE4gXwKDwHeOFfb6BJba Z1fqB81kedkXJ8VLXCOlA1G9Ltivfsj5zcbRsPF3ccmXWzZWPB0s+AL/CAtC1uKQ9y/Q==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 03, 2023 at 09:46:13AM -0400, Tamas K Lengyel wrote:
> On Mon, Oct 2, 2023 at 11:12 AM Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> >
> > Instead let map_vcpu_info() and it's call to get_page_from_gfn()
> > populate the page in the child as needed. Also remove the bogus
> > copy_domain_page(): should be placed before the call to map_vcpu_info(),
> > as the later can update the contents of the vcpu_info page.
> >
> > Note that this eliminates a bug in copy_vcpu_settings(): The function did
> > allocate a new page regardless of the GFN already having a mapping, thus in
> > particular breaking the case of two vCPU-s having their info areas on the
> > same
> > page.
> >
> > Fixes: 41548c5472a3 ('mem_sharing: VM forking')
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
Thanks, Roger.
|
