[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/10] mem_sharing/fork: do not attempt to populate vcpu_info page
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Date: Thu, 5 Oct 2023 09:15:09 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696511748; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=p1clsHo+k2GMkpiZif3stSb3kd9ZvVYXWBel3VMSWWo=; b=GkOxLjrl5npXsWQ7JQxudsHgwOdn88V3s0yRHU52LZiXaywGDyY9rxVD1hWFxdFHmytOeD+DPr+7yVJhXH8tK5IUCeE7kraEw8JBNqSBJWWrRh/r4Hd7S7q/ybaP9pmlEcktaMLzEBXEYkw2tAGuASeV8uJnQ4UUZv9IVSJJpqA=
- Arc-seal: i=1; a=rsa-sha256; t=1696511748; cv=none; d=zohomail.com; s=zohoarc; b=An7ttbDzNmkY5y1soA0g8CsYiYjvOq+cFvrFMlsuHXmMl+z0ryKFZWBQcSa6fJEh5QwB59WFuBINyO+Btz2H05y/kBTTDyh0kMXkgbwpcO6bJsl4LfBdvkIyKoxeiflKcHZeOKBitf/Oq/CSlxvRRCjEWd9/CvKZZ7HMSQDN3p8=
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, henry.wang@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 05 Oct 2023 13:16:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Oct 2, 2023 at 11:12 AM Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
>
> Instead let map_vcpu_info() and it's call to get_page_from_gfn()
> populate the page in the child as needed. Also remove the bogus
> copy_domain_page(): should be placed before the call to map_vcpu_info(),
> as the later can update the contents of the vcpu_info page.
>
> Note that this eliminates a bug in copy_vcpu_settings(): The function did
> allocate a new page regardless of the GFN already having a mapping, thus in
> particular breaking the case of two vCPU-s having their info areas on the same
> page.
>
> Fixes: 41548c5472a3 ('mem_sharing: VM forking')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Re-sending due to mailserver issues:
Acked-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
|
