[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-next v2 6/8] x86/mce: Move MC_NCLASSES into the enum mctelem_class
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 Oct 2023 09:02:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lg13GoIsI7dB1FWZ5xU2D/AIk+2JTmUdJE5NNUtXe7I=; b=UXvBa5bJc6rM9gAA3HlxmfmrMk9cPCEB3xZm2ti9ooyyCuEbn4ij4QF+M/sp2on7kwXjVXmv3SoiaYMlqxIqXLZYDV7ddmEkWuES5K+Z7YsFVxFGfH/rlmUKog2eXKnlGHN7BebDiJ7K5vUvRYvheh40SP63w+eITxerwCWUQEcQXyYya2FOQY8DuT94pmNZQcvUnZ6WicI2sC7EyYLzo6UJdD8gjk1acAKhRBTEtFkfrzMA1qH2L9bQqt1U1Ij6KlO452asuy/6gHj/qJnOoYrtiQGIKMgmVyWpWbdN4dod5DBTgNeUzyRkYI8MC+57N+3PwVlEJuInMlh0FF0lSw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDjj0F7JnG1TYdsW0DajpjMFENoBxE97d2A8vtKLuqf+ZrF5JKJ9QxXzLkTT51+NMF3Tno10B9RYOpwIzHBYub0oH76QnnWP6h6xDgw13keLOLvuOgh/NA9OSu9c3S40Xu94Nvj4Fwsu4UmASJtvvdZURgL4w6mEg3I/509xADrTmPk8ggIs1NZ93G82yo/lZ9cx0Id7lfsCvfi/zdmcrJQ+eFNRxIaHr+rEpgLnGQ+fYg5IJ0vd4Yr40zVcx4YGkcAgFCuhu2mItMopSN7W13HuUhY20cwngenffQWyB3bMRAQOPFIb/qgbI3z5krQr9/rgBSopoREUDFSRUh2ucA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 Oct 2023 07:02:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.10.2023 18:05, Nicola Vetrini wrote:
> On 16/10/2023 17:45, Jan Beulich wrote:
>> On 12.10.2023 17:28, Nicola Vetrini wrote:
>>> The definition of MC_NCLASSES contained a violation of MISRA C:2012
>>> Rule 10.1, therefore by moving it as an enumeration constant resolves
>>> the
>>> violation and makes it more resilient to possible additions to that
>>> enum.
>>
>> And using an enumerator as array dimension specifier is okay for Misra?
>> That would be odd when elsewhere named enums are treated specially.
>
> Yes, the array subscript operator is one of the few places where an enum
> can be used as
> an operand (also because negative values wouldn't compile), as opposed
> to mixing them
> with ordinary integers.
When saying "odd" I didn't even think of negative values. May I therefore
ask for the reasoning of why this specific case is deemed non-risky? To
me there looks to be a fair risk of creating undersized arrays, leading
to out-of-bounds accesses.
Jan
|
