[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/amd: Address AMD erratum #1485
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 Oct 2023 09:44:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wkze/OsYiRiiGj/wkVo7GoOtDqcT8JNdm9b2IMB2l6o=; b=dHE7/CU/HW3MeP3X+zguuodoBK18F4jrqDX3L/Jc8c1oEC415Ku8scrJ3lNH9cAYTB0/host6usDBtE/UNF64C0eUvKSOmoqtEYejQTe8pdMHZWbSokyeaSxsW1pYyq4Al+iiU2kmJef/IMHmybfw2sne67kSiBuCxaDDWmSRY10vXGfS+gUlvNChNwetyMF4gIOfaomIydHLblp+Hc/9aYa9EjhldayVzAuELDJT34sJu/S7dmFFdhmSUfSq4FJfc3qDa5/SYYvtuu/vp4BdjcI8zOEi0kYeq2kpecPwBo43DKfaVfo7tlXn5lhQqwZcwZwCqs0HBbMXo8uSxZzEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSOlABdpaSUuH4qJoU2gGvTFTzEq7w/VD6bZlV04dZh1/Rg2CwcZrZlwoquzpWJPvwybQEwMf3Qf71zq6bI9h1oZk4H4JLGPZpD53HDuvRfDC5SejoYfpel6zQBMjwmSgzKAIW4VzquzwY0cqhiyle6eWBa2ujBwjOeTFifGelTebYUsR1DfkDKeZ/LYKnCjOsNyW/TURNaitxp3+0TvzcjoaN1YaWW4xf8tFkmhSalRHoOus2bPFjD31WU1y1q8Jx/XG77a2Ik3ZqBscZVNDyUf9pH5ubzZLXPHNbghX3c2Q1oAIHeLdqiA38bJqNaBKTsXg6Pp5tW6pcMSovChDQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 17 Oct 2023 07:44:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.10.2023 17:38, Alejandro Vallejo wrote:
> Fix adapted off Linux's mailing list:
>
> https://lore.kernel.org/lkml/D99589F4-BC5D-430B-87B2-72C20370CF57@xxxxxxxxxxxxx/T/#u
Why reference the bug report when there's a proper commit (f454b18e07f5) now?
Plus in any event a short summary of the erratum would help if put right here
(without needing to look up any documents or follow any links).
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -1004,6 +1004,28 @@ static void cf_check zen2_disable_c6(void *arg)
> wrmsrl(MSR_AMD_CSTATE_CFG, val & mask);
> }
>
> +static void amd_check_erratum_1485(void)
> +{
> + uint64_t val, chickenbit = (1 << 5);
Linux gives the bit a name. Any reason you don't?
Everything else lgtm.
Jan
|
