[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH][for-4.19 v2 6/7] xen/console: make function static inline
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 17 Oct 2023 18:26:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8TMuQPdeHWRt01YLH5bBA9qWnp0bjMJGeIk7GIBDYKc=; b=P4HhvHq6R9pB+JarKLRZedIQcX6++S/2/KRvoFUNgBDrWmVUS61U8/a31/wyfteIdv2XZj/tziI+ryf7AKMZEgcs+1rwfa5SgfP0+YBplVNeGaAA0d1v9E8ojFYF66r5UlzbJeBSanIpT9XQj2dJL0QGK2ZMI39hSx89V65OaxuyKf42eGVgsszIrAxOWqsDJUpJRRkd6gE29+zmDrjURfGBEeaX2lypbNfYgr0pA/Eag0bvLFxdF4EKYxBoXE7QG8zKY4o2zrvtL2UyR/iLqNG/dhAFp4eovNyxTM111ADa31FHtSpwDMlxwxGXrW0pBAScRnPBJfZc2QaKCOgngg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SV7KEE9FhGI9f7MCAFgBbu8KaoxHct0RZ6vOf5zRG0LLGhBl+ao5cb338iQ4nkGIFRWFlr+ecVGuTNAelHILnwP93kYKTnjyfvnMnW7u7yBwk061krzeS+fBmvHEDF9C2fNXFLdXiB+yyeh8bHuKp0QvM3MmwOc5379F466Ws3XCs09sAVC6IK8myMOrMFVQhNAH6lt7KMef/X6V7+PEelkPM19qWOf3AQ7qNcDNwb60dJ2CxoYDSG1rPDVLco5kehijcyOFRwYDB9wTvub9x7Ks5iuIbpKzGw6nriYAq+3fPX5Q9FUbE/90qod1+6I24EZYHe/tE00/wKFLQhVuqg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 17 Oct 2023 16:27:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.10.2023 17:24, Nicola Vetrini wrote:
> On 16/10/2023 16:52, Jan Beulich wrote:
>> On 09.10.2023 08:54, Nicola Vetrini wrote:
>>> --- a/xen/include/xen/consoled.h
>>> +++ b/xen/include/xen/consoled.h
>>> @@ -12,7 +12,7 @@ size_t consoled_guest_tx(char c);
>>>
>>> #else
>>>
>>> -size_t consoled_guest_tx(char c) { return 0; }
>>> +static inline size_t consoled_guest_tx(char c) { return 0; }
>>
>> Why inline? We do so in headers, but we generally avoid "inline" in
>> .c files.
>
> Yes. The file modified is in fact an header.
Hmm, how did I not pay attention? Yet then a different question arises:
Without the "static inline" I'd expect this to result in a build error
from any two .c files including this header. Yet we aren't aware of
such a build issue, so I wonder whether the stub is needed in the first
place.
Jan
|
