[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Xen 4.18 pvshim console issue (with patch)
- To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 18 Oct 2023 15:29:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wvwJ9iVehLeeMjXBKTpnEazMdsJg/OvA/WoNYRO4C9s=; b=V/nZTi0zAGiU0u2qkTvqeU0LzrgiA6XTJluc08GrQvOwWWT/E95LfMHqStB/ELdItJ9i2MbqktlYDGL0lU/5xDi9sWdd8DaS/PKi/n3aj5M7scMXqXb9H0/LFYHguM3CMxt1QK/bzebVNkYfwYLlvP+lx8foGYpEJu3vZAax8LjmAwRhhrUfGIF0GYni16whAGjdKbUFfwitr2KWKOfBIoN8M4nKqUJCmRtMCsZxRTDPIY2+bMqky4IMu3X4wRhsIrrQAR2dejSFfvo0yGhsDAMCaKV1ojFsgpOqeJUJw2vFNu8hNlcQYwbzASnzGXxMQVs+6NbGQkZD8tCi9jIiow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lX4HzXSQqtxGNuJj87/4af0hpsBNZOb0/GlgUcnH7VWDK1ry/5yVidGVx5t/6eE1GcDyUIRMgNH7rNH43PaUA/btBvPv65bEV6B3TtQLEjIyTaWeXpAZ9ZAf7ZKTxDBuqziYLt8w0Mm8x7bQO4EEQyKaW5vtQZz85nZuV0ErdmXcLJt95CeZTZRXzgXZFVn2qj0ndVS2LV27y6795Ij57uz0IGinE+VxlRUb7Gnb12uZz44lO6HYutM2iPpxTDgeYw6N7c8d843X6f4Pd1gsPB4ocRCH6IsyfGE+wKVuaOHRg1wzfzQdODD0kaa/h/NA0AG7dtyxSyRTszFO45a+Gg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 18 Oct 2023 13:29:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.10.2023 12:38, Manuel Bouyer wrote:
> Hello,
> With Xen 4.18, a PV domain running under pvshim doesn't get console input.
> This is because the domain id in pvshim isn't 0 (and on x86 max_init_domid is
> hardwired to 0), so console_input_domain() will never select that domain
> as input.
>
> The attached patch fixes it by translating 0 to the real domain id for
> pvshim, but there may be a better way to do this.
My primary observation with the patch is that it presumably won't build for
other than x86. There are also indentation and other style issues, no S-o-b,
and no description. But I wonder whether a different approach doesn't want
taking: Wouldn't it help if max_init_domid was 1 in the shim case, with no
need for any other changes?
Also Cc-ing Michal as the author of the (possibly) offending patch.
Jan
|
