[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Xen 4.18 pvshim console issue (with patch)
- To: Jan Beulich <jbeulich@xxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 18 Oct 2023 16:18:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pO17vVtioHFKbYGcClS0dWe5vmQ+t96ZiIvfyxUwlJs=; b=GhaydBR1t5nGZ4N8/EO4TXoX8MzvtCY+zCRi4c6p81ogv/LTAJgFz1Zfl9so5exV5ScfezlII/RFW0dKxQupAMKn3myhqwTwhkpg1Q0XZ5ACMHlNqovKKVpld/0ylafRBMrKW+rE6CeJenrpe3rET/OGsAUriONIw1f48gC/tlEaJpYum8FE9z6HM/jOXp5QMtQPapPPSZpmpf2uxdJxownjzqziDFwgri0+BTpIZrSd1VbQzgNGJ123IVnu42DQKJ0FPqCLQQR1KUyoZmNU1E4TtjkHFtismKayh8wRbKt1SjNEc7jPYYWcMidWIqxxdld9HEZWJ/OrqNcNUU6yEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPfxnL5we/M5TE0XndVZWf9heS+gN3gAWKD91g9r79/qk9A6H7Z6RYzarUnIP44Male9K84+xV5xVMZxARfxuzV0poJWqw9a63BmbjWS8ypC937yKh+TT6WMO6KWaYWpDCiy0AWwZrtYk0UfKAmszVAMdCZrTBKNZoA+0iP51i3WeSBMmjSB/1QmEW4Y0flybVP/auIh8DpR50HgmF6OEbI1x/oHmCfTLuDt/3EqqDMXfMGfd/AmVnhJZR+rWV3uIvlWMcSGu3FyIFLYC89wOMtGWChKfHM6R6XSzMD93S+sjrvf8Dm2PhCv2/RHxVPYqox4/GfxufcRC/VnF/qE/g==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Wed, 18 Oct 2023 14:18:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 18/10/2023 15:29, Jan Beulich wrote:
>
>
> On 18.10.2023 12:38, Manuel Bouyer wrote:
>> Hello,
>> With Xen 4.18, a PV domain running under pvshim doesn't get console input.
>> This is because the domain id in pvshim isn't 0 (and on x86 max_init_domid is
>> hardwired to 0), so console_input_domain() will never select that domain
>> as input.
>>
>> The attached patch fixes it by translating 0 to the real domain id for
>> pvshim, but there may be a better way to do this.
>
> My primary observation with the patch is that it presumably won't build for
> other than x86. There are also indentation and other style issues, no S-o-b,
> and no description. But I wonder whether a different approach doesn't want
> taking: Wouldn't it help if max_init_domid was 1 in the shim case, with no
> need for any other changes?
>
> Also Cc-ing Michal as the author of the (possibly) offending patch.
What if we set max_init_domid in pvshim case to the value returned by
get_initial_domain_id()
in create_dom0()? The drawback is that we would waste some time in a loop if
the value is large.
~Michal
|
