[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Xen 4.18 pvshim console issue (with patch)
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 18 Oct 2023 16:51:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OZWQHmUuKVGWsmJQ55ZCidsb/fl8ZxeoBBYHr72tnOg=; b=igVStCFxppyP7g1qVAja2crcb05duqItKNrS3wMrVdznqApEUkfCHB1aMJO4qYHMg5fUgaczTnkQNhlPUDMXvt0s2HfyDqAIm4tLrIp/ZmVeQI0H0AIsnhmiWT9gbUjulm5W8s1Mk9YbGXC1nUynZEGmckeDRLrcxD0t+SGhH+KK7h/Ro7SUK4BEM0qReikQA+xMa4QxsqsZn/lgUQlnSe0ZtpO7VuRzUA2MNiTqFR0hmpn/tG4gNAllUhIGgEeYdRhSCTZX0+jvfoVDn8+9VR2/cYC1Y9UoU1D2W7uWNArsHeqmi7iC3zAcNEYbDKFQILX/uoQdlzOp0t2cf42gcQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBd1fc0FssCwX7PcbPJZv2P4/pjniy0W2CSlxRVMnzBcm0rlRlrvu/j0pKFf3gc9lAQ/ZAZrkEhUjewHhFC1PYo7erNB0Ewh6IDwvMcfnoaPavMOjPFDPcS5YXSLcUuSVuZFIQZbS1U6Mat60QqnYpMVEaCm8ghIKxE+CFpBTpF8XI0jfzQmYgepXiWvcXti9sVKVeS00ITGXAd2HtqeaD8GqBkv83Q/fnAo4a++875FTnm46CT3N6nKjFtPnX4RN5HtxAV9xuy/NQK5TY18dsAH0RGcsbfZx5mdhWpLw7IhfTip/lbExK72SJCgzMK5QufG6WoTJ+3lQ9CNJkA/AA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- Delivery-date: Wed, 18 Oct 2023 14:51:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.10.2023 16:18, Michal Orzel wrote:
> On 18/10/2023 15:29, Jan Beulich wrote:
>> On 18.10.2023 12:38, Manuel Bouyer wrote:
>>> Hello,
>>> With Xen 4.18, a PV domain running under pvshim doesn't get console input.
>>> This is because the domain id in pvshim isn't 0 (and on x86 max_init_domid
>>> is
>>> hardwired to 0), so console_input_domain() will never select that domain
>>> as input.
>>>
>>> The attached patch fixes it by translating 0 to the real domain id for
>>> pvshim, but there may be a better way to do this.
>>
>> My primary observation with the patch is that it presumably won't build for
>> other than x86. There are also indentation and other style issues, no S-o-b,
>> and no description. But I wonder whether a different approach doesn't want
>> taking: Wouldn't it help if max_init_domid was 1 in the shim case, with no
>> need for any other changes?
>>
>> Also Cc-ing Michal as the author of the (possibly) offending patch.
> What if we set max_init_domid in pvshim case to the value returned by
> get_initial_domain_id()
> in create_dom0()? The drawback is that we would waste some time in a loop if
> the value is large.
I'd like to avoid specifically that.
Jan
|
