[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] console: make input work again for pv-shim
- To: Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 19 Oct 2023 00:29:50 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k0bf0QTvTtO6awHU7/y5a8Ctj8jO9o+LX9Dh4nPoEXY=; b=ns0PvaPeAmHuLlHJ3iZ/nl6fG7CMmvaDSjuJyKh3i7oqaP+IxiERLcy4JJWgwUJewD8PIzmOLi0LtpVr4QiAphDD+zKErAb8m1jA8i2nIhmdKUGnC+Yhoq7rUHf1wSFRcuQm9BvCbj8zYSUYm9HVzRPpGD0/0o2992yAPcJZGTXHAIC4iLYxTTovnvWHO+fnrWJ1+nZka/M393eZPA40rU7WSQ+EVGnKOPmr+uzHuQTSOAa2rtrAT+Ql+Wv839Y7/jSrHT5w8/5YiGyXbBBk+b7gbURSKh8JOTP6KgQh+s9iSRA13MRTkbJ6IFUmo2RbIAkTxuej50RrWYDl5GbqBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bCxFfYOZgcZ7yppukoUGezJaZCCj2ZCeTQn0zzsrUfxNw/rhuGek8cUBoGP9SKNmU58Emr7SmDztfDIfylO+xYejfDvG7WEwB+JpR1yX5fdM3lJkqFLJz7fxyqB4847PCOkNsD0yWPAPiICR7ON5vQ3Jf8QPkwEqAX+6SaaVEroFiyNvITUT+X1X7W0g4kqkL9Y4QNWNqMSoqp71Jkhs0aIYjRDhjoqhyk4TNAgy1fIkG6BXOmsNiqjx20QdBCIjIVE383KK5p/Fzj72NbpGwI6bmlShgEFoPnvzyJAekV/OKW04R4UU/hTNUfnrGtsaQFaVG5hl8lMkJIk9IcStlA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- Delivery-date: Thu, 19 Oct 2023 00:30:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaAdOTgwKy6u3JYkmo1XFC1IQNE7BP1l0AgABsrIA=
- Thread-topic: [PATCH] console: make input work again for pv-shim
Hi,
> On Oct 19, 2023, at 02:00, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Jan,
>
> On 18/10/2023 15:58, Jan Beulich wrote:
>> From: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
>> The use of rcu_lock_domain_by_id() right in switch_serial_input() makes
>> assumptions about domain IDs which don't hold when in shim mode: The
>> sole (initial) domain there has a non-zero ID. Obtain the real domain ID
>> in that case (generalized as get_initial_domain_id() returns zero when
>> not in shim mode).
>> Note that console_input_domain() isn't altered, for not being used when
>> in shim mode (or more generally on x86).
>
> I think it would be worth to either add a comment in console_input_domain()
> and/or #ifdef the code. In any case...
>
>> Fixes: c2581c58bec9 ("xen/console: skip switching serial input to non
>> existing domains")
>> Signed-off-by: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> ...
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
>
>
> Also, should we consider it for xen 4.18? (I notice there is no for-4.18 tag).
Yes, so:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
