[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] console: make input work again for pv-shim
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 Oct 2023 08:35:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tBdhVf6XAkSBxABwGO1mon3mcodc9IwKa3vK1gK8scc=; b=bgFJZPo8b83xlT73otOTbFeoXLHsRNOntVqUxeVns+Dvn4N5m7+mwlVvp663ak3nTWWgbIHck5UtqsPWRyW/SXi3bbOfFqAEHHKf6UNaExuZyChaU6Y/PBpR8nMtJbiFYu+cu4HiPFoiuMdmMTSTMA2DWMEWa2VQ1tpUoTBATWSZh1BP1IoNcluO7Vam2m9JJpTlfVpYIsGkF2AXIVXxjSQvrkaXduVBuqitdpVcwftG6QW3uZHZ+4bMKTB09d4JLg4gbq1on6Uwm7xXvkPgtp+W82CUvb8LS7P43BRmnENUCyCLspE2a/kCtPoaBE0OJs4Uiyp7kinSeM8x4zOR3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aqESlWtdBCbQGMIFh2OAT3w3JTZtwt4998B5aRG3Av61S07wx4fuel5h6frYJqwO9wFP5da8w+hBS81gjCfcpDZlUGY6vw4WGmsZRgPGN/ekKv3z6UdqLbHcIN2Rf7BWhiMe9rzCPQKWfBXWGI1V01cvqxJKfXaNENwj7GoRCLH4Cz5kC/ALJb4rdV2AR4eHf/NAHGnHnC5nzdBu21Bu6XP8j35aO5dz0RKWAZ2wHu/oP2zAyNLMpqja5fCFdqexFRL5wWl0ge0F8bjGdjZp4vxmuFO+l1u4CEFLSuiWgCNNJ7sw+u02LbPmhEAoSKP0gUQApVCm9GDd2z4F8LAOtA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- Delivery-date: Thu, 19 Oct 2023 06:35:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.10.2023 20:00, Julien Grall wrote:
> On 18/10/2023 15:58, Jan Beulich wrote:
>> From: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
>>
>> The use of rcu_lock_domain_by_id() right in switch_serial_input() makes
>> assumptions about domain IDs which don't hold when in shim mode: The
>> sole (initial) domain there has a non-zero ID. Obtain the real domain ID
>> in that case (generalized as get_initial_domain_id() returns zero when
>> not in shim mode).
>>
>> Note that console_input_domain() isn't altered, for not being used when
>> in shim mode (or more generally on x86).
>
> I think it would be worth to either add a comment in
> console_input_domain() and/or #ifdef the code. In any case...
I have such a patch already, but intend to submit only for post-4.18.
>> Fixes: c2581c58bec9 ("xen/console: skip switching serial input to non
>> existing domains")
>> Signed-off-by: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> ...
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks.
> Also, should we consider it for xen 4.18? (I notice there is no for-4.18
> tag).
Of course we should, as it's a regression. I probably should have added
the tag, despite my dislike for such. Intention was imo nevertheless
clear, by me having Cc-ed Henry.
Jan
|
